Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bind csi-snapshotter to v8.0.1 #3269

Merged
merged 1 commit into from
Jun 26, 2024
Merged

Bind csi-snapshotter to v8.0.1 #3269

merged 1 commit into from
Jun 26, 2024

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Jun 26, 2024

What this PR does / why we need it:

The csi-snapshotter doesn't have an image for v8.0.2 which is used by some provider, so this PR makes sure that we use v8.0.1 everywhere.

What type of PR is this?
/kind cleanup

Special notes for your reviewer:

I have some concerns about this working properly, maybe we should test snapshotting volumes at some point or write some automated tests for that.

Does this PR introduce a user-facing change? Then add your Release Note here:

Bind `csi-snapshotter` to v8.0.1 for all providers that are supporting snapshotting the volumes

Documentation:

NONE

/assign @kron4eg

@xmudrii
Bind csi-snapshotter to v8.0.1
201a7dd 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jun 26, 2024
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@xmudrii xmudrii marked this pull request as ready for review June 26, 2024 11:23
@kubermatic-bot kubermatic-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jun 26, 2024
@kron4eg
Copy link
Member

kron4eg commented Jun 26, 2024

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bdeb8c96d762440d9f634c1b1ddadf829b474332

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2024
@kron4eg
Copy link
Member

kron4eg commented Jun 26, 2024

/cherrypick release/v1.8

@kubermatic-bot
Copy link
Contributor

@kron4eg: once the present PR merges, I will cherry-pick it on top of release/v1.8 in a new PR and assign it to you.

In response to this:

/cherrypick release/v1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubermatic-bot kubermatic-bot merged commit 28e927b into main Jun 26, 2024
13 of 14 checks passed
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.9 milestone Jun 26, 2024
@kubermatic-bot kubermatic-bot deleted the csi-snapshotter-8.0.1 branch June 26, 2024 12:14
@kubermatic-bot kubermatic-bot mentioned this pull request Jun 26, 2024
Merged
@kubermatic-bot
Copy link
Contributor

@kron4eg: new pull request created: #3270

In response to this:

/cherrypick release/v1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@xmudrii xmudrii mentioned this pull request Jun 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.9
Development

Successfully merging this pull request may close these issues.
3 participants
@xmudrii @kubermatic-bot @kron4eg