Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install apparmor-utils to include apparmor_parser on Hetzner Baremetal Ubuntu Servers #3233

Merged
merged 1 commit into from
Jun 18, 2024
Merged

Install apparmor-utils to include apparmor_parser on Hetzner Baremetal Ubuntu Servers #3233

merged 1 commit into from
Jun 18, 2024

Conversation

mohamed-rafraf
Copy link
Member

@mohamed-rafraf mohamed-rafraf commented Jun 18, 2024 •
edited
Loading

What this PR does / why we need it:

Ensures apparmor_parser is installed by adding the apparmor-utils package, and fixing kubelet container start issues on Hetzner Baremetal Ubuntu Servers.

Which issue(s) this PR fixes:

Fixes #2133

What type of PR is this?

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Ensure `apparmor-utils` package is installed on Ubuntu as it's required for `kubelet` to function properly

Documentation:

NONE

@kubermatic-bot kubermatic-bot added docs/none Denotes a PR that doesn't need documentation (changes). release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 18, 2024
@mohamed-rafraf
Copy link
Member Author

/assign
/cc @xmudrii

@kron4eg
Copy link
Member

kron4eg commented Jun 18, 2024

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0d6854094f5323ba000bc457f33ec6da210cedf3

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2024
xmudrii
xmudrii approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind bug
/lgtm
/approve

@kubermatic-bot kubermatic-bot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jun 18, 2024
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xmudrii
Copy link
Member

xmudrii commented Jun 18, 2024

@mohamed-rafraf Can you add a release note about this change? Something like:

Ensure `apparmor-utils` package is installed on Ubuntu as it's required for `kubelet` to function properly

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Jun 18, 2024
@kubermatic-bot kubermatic-bot merged commit 3a8e3ac into kubermatic:main Jun 18, 2024
14 checks passed
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.9 milestone Jun 18, 2024
@xmudrii
Copy link
Member

xmudrii commented Jun 18, 2024

/cherrypick release/v1.8

@xmudrii
Copy link
Member

xmudrii commented Jun 18, 2024

/cherrypick release/v1.7

@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #3235

In response to this:

/cherrypick release/v1.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Jun 18, 2024
Merged
Merged
@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #3236

In response to this:

/cherrypick release/v1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@kron4eg kron4eg

@xmudrii xmudrii

@mohamed-rafraf mohamed-rafraf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.9
Development

Successfully merging this pull request may close these issues.

Install the apparmor_praser binary by default
4 participants
@mohamed-rafraf @kron4eg @kubermatic-bot @xmudrii