Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update canal to v3.28.0 #3216

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Conversation

samuelfischer
Copy link
Contributor

@samuelfischer samuelfischer commented Jun 14, 2024

What this PR does / why we need it:
Continues #3214 to update canal-cni.

Additionally fixes Critical CVEs in the older flannel image ( CVE-2023-38545, CVE-2023-26463, CVE-2023-41913 ).

Which issue(s) this PR fixes:
Fixes #3206 (the first Task, the others should be fixed by the preceding PR)

What type of PR is this?
/kind feature

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Update canal to v3.28.0

Documentation:

Do we need a hint to https://docs.tigera.io/calico/latest/release-notes/#important-upgrade-notes and that restarts of calico controllers might be necessary after the update?
Not sure how to handle that.

NONE

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 14, 2024
@kubermatic-bot
Copy link
Contributor

Hi @samuelfischer. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 14, 2024
@kron4eg
Copy link
Member

kron4eg commented Jun 16, 2024

@samuelfischer hey and thanks for the PR.

Additionally fixes Critical CVEs in the older flannel image

What CVE are you referring to?

@samuelfischer
Copy link
Contributor Author

@samuelfischer hey and thanks for the PR.

Additionally fixes Critical CVEs in the older flannel image

What CVE are you referring to?

Ah sorry, I missed adding the CVEs on Friday - added them to the Description now.
Two are for "strongSwan" and one for "libcurl" in the image.

Re-checking the image again today I also saw two golang stdlib CVEs in the go version of flanneld - both will also be fixed by the update (CVE-2023-24538, CVE-2023-24540).

Signed-off-by: Samuel Fischer <samuel.fischer@scandio.de>
@samuelfischer
Copy link
Contributor Author

rebased to fix conflicts after Merge of #3214

@kron4eg
Copy link
Member

kron4eg commented Jun 17, 2024

/test all

@kron4eg
Copy link
Member

kron4eg commented Jun 17, 2024

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1df257d94d80021a99c95064c8ab39d16ac33504

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2024
@kubermatic-bot kubermatic-bot merged commit 5c3dd92 into kubermatic:main Jun 17, 2024
13 of 14 checks passed
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.9 milestone Jun 17, 2024
@samuelfischer samuelfischer deleted the canal-v.3.28.0 branch June 17, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update images to support Kubernetes 1.30
3 participants