-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow upgrade to the same Kubernetes version #315
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
LGTM label has been added. Git tree hash: 93ad7713683829befe1b69762c22a737df09e86e
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
0873310
to
8755dcf
Compare
/lgtm |
LGTM label has been added. Git tree hash: da663cd507c71a7ca6d6ac5f2c4ec10a8d106cc9
|
/test pull-kubeone-e2e-aws-conformance-1.13.5 |
/test pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0 |
/test pull-kubeone-e2e-aws-conformance-1.13.5 |
/hold cancel |
@xmudrii: Overrode contexts on behalf of xmudrii: pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0 |
@xmudrii: Overrode contexts on behalf of xmudrii: pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-kubeone-e2e-aws-conformance-1.14.0 |
@xmudrii: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/override pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0 |
@xmudrii: Overrode contexts on behalf of xmudrii: pull-kubeone-e2e-digitalocean-upgrade-1.13.5-1.14.0 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This PR changes the update preflight checks to allow updating to the same version if the
--force
flag is used. This ensure we can retry if the upgrade process failed for any reason.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):xref #269
Release note:
/assign @kron4eg