Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: debian apt-get update running before configuring repositories #3076

Merged
merged 6 commits into from
Mar 13, 2024
Merged

fix: debian apt-get update running before configuring repositories #3076

merged 6 commits into from
Mar 13, 2024

Conversation

cnvergence
Copy link
Member

@cnvergence cnvergence commented Mar 11, 2024 •
edited by kubermatic-bot
Loading

What this PR does / why we need it:
In debian script we were running apt-get update before configuring new repositories for Kubernetes.
When upgrading the KubeOne cluster before these changes, it can lead to an error with trying to download Kubernetes release from deprecated packages.cloud.google.com.

Which issue(s) this PR fixes:

Fixes #3077

What type of PR is this?

/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Fix cluster upgrades on Debian hosts with deprecated Kubernetes repositories

Documentation:

TBD

@cnvergence
fix: debian apt-get update running before configuring repositories
8d6ce8c 
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
@kubermatic-bot kubermatic-bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. docs/tbd Denotes a PR that needs documentation (change) that will be done later. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 11, 2024
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 11, 2024
@cnvergence cnvergence marked this pull request as ready for review March 11, 2024 12:48
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 11, 2024
@cnvergence
remove additional apt-get update
123beae 
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
xmudrii
xmudrii reviewed Mar 11, 2024
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The apt-containerd template includes apt-get update, so while it's not explicit, it's still there. I think that .INSTALL_CONTAINERD is always true, we don't support other or external container runtimes.

Are you running into any specific issue that requires this change?

pkg/scripts/os_debian.go Outdated Show resolved Hide resolved
@cnvergence cnvergence marked this pull request as draft March 11, 2024 13:15
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 11, 2024
@cnvergence
update testdata
dc2dc3f 
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
@kubermatic-bot kubermatic-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 11, 2024
@cnvergence
remove old kubernetes.list from apt sources
d8f5aa6 
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
@cnvergence
remove old kubernetes.list from apt sources
ee207ed 
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
@cnvergence cnvergence marked this pull request as ready for review March 12, 2024 12:31
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 12, 2024
@cnvergence
Copy link
Member Author

/kind bug

@kubermatic-bot kubermatic-bot added kind/bug Categorizes issue or PR as related to a bug. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Mar 12, 2024
@cnvergence
fix typos
3d71451 
Signed-off-by: Karol Szwaj <karol.szwaj@gmail.com>
@cnvergence cnvergence requested a review from xmudrii March 12, 2024 14:10
xmudrii
xmudrii approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @cnvergence!
/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 13, 2024
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7b39d4a7300bbc8b40dbbb012d6a3eb6b6657442

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2024
@xmudrii
Copy link
Member

xmudrii commented Mar 13, 2024

/cherrypick release/v1.7

@kubermatic-bot
Copy link
Contributor

@xmudrii: once the present PR merges, I will cherry-pick it on top of release/v1.7 in a new PR and assign it to you.

In response to this:

/cherrypick release/v1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xmudrii
Copy link
Member

xmudrii commented Mar 13, 2024

/cherrypick release/v1.6

@kubermatic-bot
Copy link
Contributor

@xmudrii: once the present PR merges, I will cherry-pick it on top of release/v1.6 in a new PR and assign it to you.

In response to this:

/cherrypick release/v1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot merged commit 99d8f3b into kubermatic:main Mar 13, 2024
14 checks passed
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.8 milestone Mar 13, 2024
@kubermatic-bot kubermatic-bot mentioned this pull request Mar 13, 2024
Merged
@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #3083

In response to this:

/cherrypick release/v1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot mentioned this pull request Mar 13, 2024
Merged
@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #3084

In response to this:

/cherrypick release/v1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cnvergence cnvergence deleted the fix-aptget branch April 5, 2024 16:03
@xmudrii
Copy link
Member

xmudrii commented May 2, 2024

/release-note-edit

Fix cluster upgrades on Debian hosts with deprecated Kubernetes repositories

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/tbd Denotes a PR that needs documentation (change) that will be done later. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.8
Development

Successfully merging this pull request may close these issues.

apt-get update fails on debian hosts
3 participants
@cnvergence @kubermatic-bot @xmudrii