Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS terraform example - allow using non-default VPC #306

Merged
merged 3 commits into from
Mar 25, 2019
Merged

AWS terraform example - allow using non-default VPC #306

merged 3 commits into from
Mar 25, 2019

Conversation

kdomanski
Copy link
Contributor

Release note:

NONE

@kubermatic-bot kubermatic-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 25, 2019
xmudrii
xmudrii reviewed Mar 25, 2019
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny nitpick, otherwise lgtm.

examples/terraform/aws/variables.tf
@@ -23,6 +23,10 @@ variable "aws_region" {
description = "AWS region to speak to"
}

variable "vpc_id" {
description = "VPC to use ('default' for default VPC)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we default this to default instead of writing what's usual default in the description?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. and removed dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. labels Mar 25, 2019
@kdomanski
AWS terraform: allow using non-default VPC
aa6edae 
Signed-off-by: Kamil Domański <kamil@domanski.co>
@kdomanski
fix typos in IAM resource names
21c5089 
Signed-off-by: Kamil Domański <kamil@domanski.co>
@kdomanski
update deprecated T2 AWS nodes
c9b7eba 
Signed-off-by: Kamil Domański <kamil@domanski.co>
@kdomanski
Copy link
Contributor Author

/test pull-kubeone-e2e-aws

@kron4eg
Copy link
Member

kron4eg commented Mar 25, 2019

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2019
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6e3eea0843ee3968d57cfd3db98a8beb3e87e075

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2019
@kubermatic-bot kubermatic-bot merged commit 1e60686 into master Mar 25, 2019
@kubermatic-bot kubermatic-bot deleted the aws-custom-vpc branch March 25, 2019 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii left review comments

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kdomanski @kron4eg @kubermatic-bot @xmudrii