Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop containerRuntimeEndpoint field from KubeletConfiguration #2939

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Oct 30, 2023

What this PR does / why we need it:

The containerRuntimeEndpoint field has been introduced in Kubernetes v1.27. This is causing the following error when running kubeadm init and kubeadm join on Kubernetes versions prior to 1.27:

[172.31.120.97] W1030 16:39:28.325293   11979 initconfiguration.go:305] error unmarshaling configuration schema.GroupVersionKind{Group:"kubelet.config.k8s.io", Version:"v1beta1", Kind:"KubeletConfiguration"}: strict decoding error: unknown field "containerRuntimeEndpoint"

Given that we don't use this field at this time, we can just drop it for now.

What type of PR is this?
/kind bug

Does this PR introduce a user-facing change? Then add your Release Note here:

Drop `containerRuntimeEndpoint` field from KubeletConfiguration to fix warning from `kubeadm init` and `kubeadm join` for clusters running Kubernetes prior to 1.27

Documentation:

NONE

/assign @kron4eg @ahmedwaleedmalik

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot added kind/bug Categorizes issue or PR as related to a bug. docs/none Denotes a PR that doesn't need documentation (changes). release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Oct 30, 2023
@kubermatic-bot kubermatic-bot added the dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. label Oct 30, 2023
@xmudrii
Copy link
Member Author

xmudrii commented Oct 30, 2023

/cherrypick release/v1.7

@kubermatic-bot
Copy link
Contributor

@xmudrii: once the present PR merges, I will cherry-pick it on top of release/v1.7 in a new PR and assign it to you.

In response to this:

/cherrypick release/v1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 30, 2023
@xmudrii
Copy link
Member Author

xmudrii commented Oct 30, 2023

/retest

@kron4eg
Copy link
Member

kron4eg commented Oct 30, 2023

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 56eac97ad70edd899088e1a12522b44ab365d634

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2023
@kubermatic-bot kubermatic-bot merged commit 17f2959 into main Oct 30, 2023
13 checks passed
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.8 milestone Oct 30, 2023
@kubermatic-bot kubermatic-bot deleted the drop-kubelet-field branch October 30, 2023 18:08
@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #2940

In response to this:

/cherrypick release/v1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants