Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to the community-hosted package repositories (pkgs.k8s.io) and to dl.k8s.io #2873

Merged
merged 6 commits into from
Aug 31, 2023

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Aug 28, 2023

What this PR does / why we need it:

There are three changes introduced in this PR:

  • Migrate to the community-hosted package repositories (pkgs.k8s.io) from the deprecated Google-hosted package repository (apt.kubernetes.io and yum.kubernetes.io)
    • The Kubernetes project strongly encourages and recommends migrating to the new package repositories as soon as possible
    • Given that the Google-hosted repository is deprecated, I decided to do unconditional migration, i.e. without giving an option to opt-out from this change. This is going to make it easier for us to maintain and support this release branch in the long term. Moreover, most users are not going to notice this change at all. This change might only affect users allowlisting traffic based on IP addresses or URLs, in which case they need to update their allowlists (this is explained in the release note)
  • Migrate to dl.k8s.io instead of pulling binaries from the release bucket directly
  • The kubernetes-release bucket might get deprecated and frozen in the future as part of efforts to migrate to the community-owned infrastructure. The Kubernetes project strongly recommends using dl.k8s.io going forward
  • Same as the previous change, this change shouldn't affect many users. Additionally, this only affects Flatcar-based clusters. Users using allowlisting might need to update their configuration and this is explained in the release note
  • cri-tools is updated to v1.27.1 for clusters running Kubernetes 1.27. Kubernetes 1.28 clusters will use cri-tools v1.28.0

Additionally, tests are updated to use KubeOne 1.6 as the stable version for initially provisioning the cluster.

Which issue(s) this PR fixes:
Fixes #2870

What type of PR is this?

/kind feature

Does this PR introduce a user-facing change? Then add your Release Note here:

- [ACTION REQUIRED] Migrate from the legacy package repositories (`apt.kubernetes.io` and `yum.kubernetes.io`) to the Kubernetes community-hosted package repositories (`pkgs.k8s.io`). The legacy repositories [have been deprecated as of August 31, 2023 and will be frozen starting from September 13, 2023](https://kubernetes.io/blog/2023/08/31/legacy-package-repository-deprecation/). Upgrading to KubeOne v1.7.0+ or v1.6.3+ is required in order to install or upgrade to Kubernetes version newer than v1.27.6, v1.26.9, and v1.25.14. **If IP-based or URL-based filtering is in place**, you may need to mirror the release packages to a local package repository that you have strict control over. See [the official announcement](https://kubernetes.io/blog/2023/08/15/pkgs-k8s-io-introduction/) for more details
- [ACTION REQUIRED] Migrate from the Kubernetes release bucket (`https://storage.googleapis.com/kubernetes-release/release`) to `dl.k8s.io` for downloading binaries. This change only affects Flatcar-based clusters. **If IP-based or URL-based filtering is in place**, you need to allow the appropriate IP addresses and domains as described in [the official `dl.k8s.io` announcement](https://kubernetes.io/blog/2023/06/09/dl-adopt-cdn/)
- Upgrade cri-tools to v1.27.1 for clusters running Kubernetes 1.27

Documentation:

TBD

(this should be mentioned in the upgrade guide)

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot added docs/tbd Denotes a PR that needs documentation (change) that will be done later. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Aug 28, 2023
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 28, 2023
@xmudrii xmudrii self-assigned this Aug 28, 2023
@xmudrii xmudrii requested a review from kron4eg August 28, 2023 21:22
@xmudrii
Copy link
Member Author

xmudrii commented Aug 28, 2023

/cherrypick release/v1.6

@kubermatic-bot
Copy link
Contributor

@xmudrii: once the present PR merges, I will cherry-pick it on top of release/v1.6 in a new PR and assign it to you.

In response to this:

/cherrypick release/v1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xmudrii
Copy link
Member Author

xmudrii commented Aug 28, 2023

/test pull-kubeone-e2e-aws-amzn-install-containerd-external-v1.27.3
/test pull-kubeone-e2e-aws-centos-install-containerd-external-v1.27.3
/test pull-kubeone-e2e-aws-default-install-containerd-external-v1.27.3
/test pull-kubeone-e2e-aws-flatcar-install-containerd-external-v1.27.3

@xmudrii
Copy link
Member Author

xmudrii commented Aug 28, 2023

/test pull-kubeone-e2e-aws-rhel-install-containerd-external-v1.27.3
/test pull-kubeone-e2e-aws-rockylinux-install-containerd-external-v1.27.3

@xmudrii
Copy link
Member Author

xmudrii commented Aug 29, 2023

/test pull-kubeone-e2e-azure-centos-install-containerd-external-v1.27.3
/test pull-kubeone-e2e-azure-default-install-containerd-external-v1.27.3
/test pull-kubeone-e2e-azure-rhel-install-containerd-external-v1.27.3

@xmudrii
Copy link
Member Author

xmudrii commented Aug 29, 2023

/test pull-kubeone-e2e-azure-flatcar-install-containerd-external-v1.27.3
/test pull-kubeone-e2e-azure-rockylinux-install-containerd-external-v1.27.3
/test pull-kubeone-e2e-openstack-default-install-containerd-external-v1.27.3

@kron4eg
Copy link
Member

kron4eg commented Aug 29, 2023

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e4739a969a6f3f4d12096dd8b62495e43a3a3e2a

@kron4eg
Copy link
Member

kron4eg commented Aug 29, 2023

/approve

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 29, 2023
@kron4eg
Copy link
Member

kron4eg commented Aug 29, 2023

/retest

1 similar comment
@kron4eg
Copy link
Member

kron4eg commented Aug 29, 2023

/retest

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2023
@xmudrii
Copy link
Member Author

xmudrii commented Aug 29, 2023

/test pull-kubeone-e2e-aws-amzn-stable-upgrade-containerd-external-from-v1.26.6-to-v1.27.3
/test pull-kubeone-e2e-aws-centos-stable-upgrade-containerd-external-from-v1.26.6-to-v1.27.3
/test pull-kubeone-e2e-aws-default-stable-upgrade-containerd-external-from-v1.26.6-to-v1.27.3

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 30, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 806fb5c7b485a40ba70c6cd890e963cbfeb306b2

@xmudrii
Copy link
Member Author

xmudrii commented Aug 30, 2023

/test pull-kubeone-e2e-aws-centos-stable-upgrade-containerd-external-from-v1.26.6-to-v1.27.3

@kubermatic-bot kubermatic-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 30, 2023
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Copy link
Member Author

xmudrii commented Aug 30, 2023

/test pull-kubeone-e2e-aws-amzn-stable-upgrade-containerd-external-from-v1.26.6-to-v1.27.3
/test pull-kubeone-e2e-aws-centos-stable-upgrade-containerd-external-from-v1.26.6-to-v1.27.3

@xmudrii
Copy link
Member Author

xmudrii commented Aug 30, 2023

/test pull-kubeone-e2e-aws-rhel-stable-upgrade-containerd-external-from-v1.26.6-to-v1.27.3
/test pull-kubeone-e2e-aws-rockylinux-stable-upgrade-containerd-external-from-v1.26.6-to-v1.27.3
/test pull-kubeone-e2e-aws-default-stable-upgrade-containerd-external-from-v1.26.6-to-v1.27.3
/test pull-kubeone-e2e-aws-flatcar-stable-upgrade-containerd-external-from-v1.26.6-to-v1.27.3

@xmudrii
Copy link
Member Author

xmudrii commented Aug 30, 2023

/test pull-kubeone-e2e-openstack-centos-stable-upgrade-containerd-external-from-v1.26.6-to-v1.27.3

@xmudrii xmudrii marked this pull request as ready for review August 30, 2023 16:18
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 30, 2023
@kubermatic-bot
Copy link
Contributor

kubermatic-bot commented Aug 30, 2023

@xmudrii: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubeone-e2e-openstack-default-install-containerd-external-v1.27.3 8a5e4c9 link true /test pull-kubeone-e2e-openstack-default-install-containerd-external-v1.27.3

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xmudrii
Copy link
Member Author

xmudrii commented Aug 30, 2023

/retest

Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 31, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2fc65a7875fdbbd6058189b56a37fd0f4bdeb580

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmedwaleedmalik,kron4eg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit b8a1b46 into main Aug 31, 2023
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.7 milestone Aug 31, 2023
@kubermatic-bot kubermatic-bot deleted the pkgs-k8s-io branch August 31, 2023 09:48
@kubermatic-bot
Copy link
Contributor

@xmudrii: #2873 failed to apply on top of branch "release/v1.6":

Applying: Migrate to pkgs.k8s.io
Applying: Migrate to dl.k8s.io
Applying: Update fixtures
Applying: Use release/v1.6 as a stable version for upgrade tests
Using index info to reconstruct a base tree...
M	test/e2e/prow.yaml
M	test/e2e/scenario_upgrade.go
M	test/tests.yml
Falling back to patching base and 3-way merge...
Auto-merging test/tests.yml
CONFLICT (content): Merge conflict in test/tests.yml
Auto-merging test/e2e/scenario_upgrade.go
Auto-merging test/e2e/prow.yaml
CONFLICT (content): Merge conflict in test/e2e/prow.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0004 Use release/v1.6 as a stable version for upgrade tests
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release/v1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xmudrii xmudrii added the backport-complete Denotes a PR or issue which has been fully backported to all required release branches. label Sep 7, 2023
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-complete Denotes a PR or issue which has been fully backported to all required release branches. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/tbd Denotes a PR that needs documentation (change) that will be done later. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the new Kubernetes community-owned repositories (pkgs.k8s.io) for installing packages
4 participants