Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.4] Update etcd to 3.5.6 and enable compact hash checks #2500

Merged
merged 1 commit into from
Nov 24, 2022
Merged

[release/v1.4] Update etcd to 3.5.6 and enable compact hash checks #2500

merged 1 commit into from
Nov 24, 2022

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Nov 24, 2022

What this PR does / why we need it:

This is a manual cherry-pick of #2497 to the release/v1.4 branch.

What type of PR is this?

/kind feature

Does this PR introduce a user-facing change? Then add your Release Note here:

- Update etcd to 3.5.6 which includes a fix for [the recently reported data inconsistency issue for a case when etcd crashes during processing defragmentation operation](https://groups.google.com/a/kubernetes.io/g/dev/c/sEVopPxKPDo/m/9ME3CzicBwAJ)
- Enable compact hash checks as per [the recommendations from etcd for detecting data corruption](https://etcd.io/docs/v3.5/op-guide/data_corruption/#enabling-data-corruption-detection)

Documentation:

NONE

@xmudrii
Update etcd to 3.5.6 and enable compact hash checks
ffcbc44 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii requested a review from kron4eg November 24, 2022 14:30
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 24, 2022
@kron4eg kron4eg changed the title Update etcd to 3.5.6 and enable compact hash checks [release/v1.4] Update etcd to 3.5.6 and enable compact hash checks Nov 24, 2022
@kron4eg
Copy link
Member

kron4eg commented Nov 24, 2022

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 24, 2022
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: af002d2f8b071e68f0dd4ab870e1eaf947d3ef7c

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2022
@kubermatic-bot kubermatic-bot merged commit 8e18a13 into release/v1.4 Nov 24, 2022
@kubermatic-bot kubermatic-bot deleted the etcd-3.5.6-1.4 branch November 24, 2022 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg Awaiting requested review from kron4eg

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xmudrii @kron4eg @kubermatic-bot