Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.5] Make vSphere E2E tests work on the new vSphere infrastructure #2449

Merged
merged 5 commits into from
Nov 7, 2022
Merged

[release/v1.5] Make vSphere E2E tests work on the new vSphere infrastructure #2449

merged 5 commits into from
Nov 7, 2022

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Nov 7, 2022

What this PR does / why we need it:

This PR is a manual cherry-pick of #2432 to the release/v1.5 branch.

What type of PR is this?

/kind feature
/kind chore

Does this PR introduce a user-facing change? Then add your Release Note here:

Add `allow_insecure` variable (default `false`) to Terraform configs for vSphere. The value of this variable is propagated to the MachineDeployment template in `output.tf`

Documentation:

https://github.com/kubermatic/docs/pull/1237

@xmudrii
Add allow_insecure Terraform variable for vSphere
b14a7c1 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Make vSphere Ubuntu E2E tests use the new vSphere infra
8ef1e97 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Add Terraform configs for vSphere on CentOS
c7ca959 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Address TODO comments
9e1d3c7 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii
Add E2E tests for CentOS 7 on vSphere
aa3a024 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii requested a review from kron4eg November 7, 2022 14:47
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/chore Updating grunt tasks etc; no production code changes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 7, 2022
@kron4eg
Copy link
Member

kron4eg commented Nov 7, 2022

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2022
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d389e4802c44c87f0d320f17bef0e94e95fe7775

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2022
@xmudrii
Copy link
Member Author

xmudrii commented Nov 7, 2022

/retest

2 similar comments
@xmudrii
Copy link
Member Author

xmudrii commented Nov 7, 2022

/retest

@xmudrii
Copy link
Member Author

xmudrii commented Nov 7, 2022

/retest

@xmudrii
Copy link
Member Author

xmudrii commented Nov 7, 2022

/test all

@kubermatic-bot kubermatic-bot merged commit 8e62a66 into release/v1.5 Nov 7, 2022
@kubermatic-bot kubermatic-bot deleted the vsphere-tests-1.5 branch November 7, 2022 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg Awaiting requested review from kron4eg

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/chore Updating grunt tasks etc; no production code changes. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xmudrii @kron4eg @kubermatic-bot