Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling IPv6 for Hubble UI #2448

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Allow disabling IPv6 for Hubble UI #2448

merged 1 commit into from
Nov 7, 2022

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Nov 7, 2022

What this PR does / why we need it:

This PR introduces a new parameter for the Cilium addon called HubbleIPv6. This parameter is used to enable/disable Hubble UI listening on an IPv6 interface. By default, the value of this parameter is true which means that Hubble UI is listening on an IPv6 interface, and it can be set to false to disable listening on IPv6.

Example:

...
addons:
  enable: true
  addons:
    - name: cni-cilium
      params:
        HubbleIPv6: "true"

Which issue(s) this PR fixes:
Fixes #2446

What type of PR is this?

/kind feature

Does this PR introduce a user-facing change? Then add your Release Note here:

Add a new addon parameter called `HubbleIPv6` (`true`/`false`, default: `true`) for Cilium CNI used to enable/disable Hubble UI listening on an IPv6 interface

Documentation:

NONE

@xmudrii xmudrii added the backport-needed Denotes a PR or issue that has not been fully backported. label Nov 7, 2022
@xmudrii xmudrii requested a review from kron4eg November 7, 2022 14:16
@kubermatic-bot kubermatic-bot added kind/feature Categorizes issue or PR as related to a new feature. docs/none Denotes a PR that doesn't need documentation (changes). release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 7, 2022
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii requested a review from kron4eg November 7, 2022 14:23
@kubermatic-bot kubermatic-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 7, 2022
@kron4eg
Copy link
Member

kron4eg commented Nov 7, 2022

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 673c038ecd3330f5e0d2c8b412a6d32a633d9e32

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2022
@kubermatic-bot kubermatic-bot merged commit fa4640c into main Nov 7, 2022
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.6 milestone Nov 7, 2022
@kubermatic-bot kubermatic-bot deleted the hubble-ipv6 branch November 7, 2022 15:26
@xmudrii
Copy link
Member Author

xmudrii commented Nov 7, 2022

/cherrypick release/v1.5

@xmudrii
Copy link
Member Author

xmudrii commented Nov 7, 2022

/cherrypick release/v1.4

@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #2451

In response to this:

/cherrypick release/v1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot
Copy link
Contributor

@xmudrii: #2448 failed to apply on top of branch "release/v1.4":

Applying: Allow disabling IPv6 for Hubble UI
Using index info to reconstruct a base tree...
M	addons/cni-cilium/cilium.yaml
Falling back to patching base and 3-way merge...
Auto-merging addons/cni-cilium/cilium.yaml
CONFLICT (content): Merge conflict in addons/cni-cilium/cilium.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Allow disabling IPv6 for Hubble UI
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release/v1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xmudrii xmudrii added backport-complete Denotes a PR or issue which has been fully backported to all required release branches. and removed backport-needed Denotes a PR or issue that has not been fully backported. labels Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-complete Denotes a PR or issue which has been fully backported to all required release branches. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hubble UI is crash looping
3 participants