Refactor validation for csiConfig #2430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
kubermatic-bot
added
kind/api-change
|
/retest |
xmudrii
added
the
backport-needed
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
LGTM label has been added. Git tree hash: c7ddded7f9e7226b47cfed0c9850ca5f0fa43b6c
|
kubermatic-bot
added
the
approved
|
/cherrypick release/v1.5 |
|
@xmudrii: new pull request created: #2447 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
xmudrii
added
backport-complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
After discussing internally with @kron4eg, we decided to make it possible to provide
.cloudProvider.csiConfigeven if the in-tree provider is used. This needed to make implementing E2E tests easier/possible, as well as, to make it easier to test vSphere integration manually (e.g. you don't need to delete/commentcsiConfigeach time you want to test something).In such cases when CSIConfig is used with the in-tree provider, the CSIConfig is ignored and a warning about this is printed.
Additionally, CSIConfig is now a mandatory field for vSphere if external is enabled. This wasn't the case before, however, if you don't provide CSIConfig, vSphere CSI will crashloop, resulting in a non-functional cluster.
What type of PR is this?
/kind api-change
Does this PR introduce a user-facing change? Then add your Release Note here:
Documentation: