Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Machine Controller Addon: add metrics port 8080 #2421

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Machine Controller Addon: add metrics port 8080 #2421

merged 1 commit into from
Nov 1, 2022

Conversation

sphr2k
Copy link
Contributor

@sphr2k sphr2k commented Oct 25, 2022 •
edited
Loading

Add metrics port (8080/TCP) to Machine Controller addon, so Prometheus ServiceMonitor can be used

Signed-off-by: sphr2k mail@janwerner.de

What this PR does / why we need it:

Expose machine-controller metrics port (8080/TCP), so Prometheus ServiceMonitor can be used for scraping

Expose machine-controller metrics port (8080/TCP), so Prometheus ServiceMonitor can be used for scraping

NONE

@sphr2k
Machine Controller Addon: add metrics port 8080
088aec4 
Add metrics port (8080/TCP) to Machine Controller addon, so Prometheus ServiceMonitor can be used

Signed-off-by: sphr2k <mail@janwerner.de>
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 25, 2022
@kubermatic-bot
Copy link
Contributor

Hi @sphr2k. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 25, 2022
@xmudrii
Copy link
Member

xmudrii commented Oct 25, 2022

@sphr2k Thank you for your contribution! Can you please edit your PR description to add proper release note and documentation blocks? For example:

```release-note
NONE
```

```documentation
NONE
```

/test all

@xmudrii
Copy link
Member

xmudrii commented Oct 25, 2022

/kind cleanup

@kubermatic-bot kubermatic-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. docs/none Denotes a PR that doesn't need documentation (changes). release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/docs-needed Indicates that a PR should not merge because it's missing one of the documentation labels. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Oct 25, 2022
ahmedwaleedmalik
ahmedwaleedmalik approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 1, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 45db006a6c19df169ee8bb5bcaabb79c904452e2

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2022
xmudrii
xmudrii approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/retest

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahmedwaleedmalik,xmudrii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit e7e5340 into kubermatic:main Nov 1, 2022
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.6 milestone Nov 1, 2022
@xmudrii xmudrii added the backport-needed Denotes a PR or issue that has not been fully backported. label Nov 1, 2022
@xmudrii
Copy link
Member

xmudrii commented Nov 3, 2022

/cherrypick release/v1.5

@xmudrii
Copy link
Member

xmudrii commented Nov 3, 2022

/cherrypick release/v1.4

@kubermatic-bot kubermatic-bot mentioned this pull request Nov 3, 2022
Merged
@kubermatic-bot kubermatic-bot mentioned this pull request Nov 3, 2022
Merged
@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #2439

In response to this:

/cherrypick release/v1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #2440

In response to this:

/cherrypick release/v1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xmudrii xmudrii added backport-complete Denotes a PR or issue which has been fully backported to all required release branches. and removed backport-needed Denotes a PR or issue that has not been fully backported. labels Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedwaleedmalik ahmedwaleedmalik ahmedwaleedmalik approved these changes

@xmudrii xmudrii xmudrii approved these changes

Assignees

@ahmedwaleedmalik ahmedwaleedmalik

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-complete Denotes a PR or issue which has been fully backported to all required release branches. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.6
Development

Successfully merging this pull request may close these issues.
4 participants
@sphr2k @kubermatic-bot @xmudrii @ahmedwaleedmalik