Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update x/crypto to fix issues with authenticating over SSH #2390

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Sep 28, 2022

What this PR does / why we need it:

Newer OpenSSH versions changed allowed algorithms and keys, so it's not possible to SSH to instances running newer OpenSSH with an older x/crypto dependency. This PR updates the dependency to a newer version to fix this issue.

What type of PR is this?

/kind bug

Does this PR introduce a user-facing change? Then add your Release Note here:

Update `golang.org/x/crypto` dependency to a newer version to fix issues with SSH authentication on instances with newer OpenSSH versions

Documentation:

NONE

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 28, 2022
@kron4eg
Copy link
Member

kron4eg commented Sep 28, 2022

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 28, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5d2c9c03533bdf7ebe80abafde6782c0e8ad26f6

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 28, 2022
@xmudrii
Copy link
Member Author

xmudrii commented Sep 28, 2022

/hold
let's run some E2E tests

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 28, 2022
@xmudrii
Copy link
Member Author

xmudrii commented Sep 28, 2022

/test pull-kubeone-e2e-aws-conformance-1.23

@xmudrii
Copy link
Member Author

xmudrii commented Sep 28, 2022

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 28, 2022
@kubermatic-bot kubermatic-bot merged commit 141668d into release/v1.4 Sep 28, 2022
@kubermatic-bot kubermatic-bot deleted the fix-ssh branch September 28, 2022 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants