Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New NodeLocalDNS API field #2356

Merged
merged 3 commits into from
Sep 21, 2022
Merged

New NodeLocalDNS API field #2356

merged 3 commits into from
Sep 21, 2022

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Sep 20, 2022 •
edited by xmudrii
Loading

Which issue(s) this PR fixes:

Fixes #2235

What type of PR is this?
/kind feature
/kind api-change

Does this PR introduce a user-facing change? Then add your Release Note here:

Add a new `NodeLocalDNS` field to the KubeOneCluster API used to control should the NodeLocalDNSCache component be deployed or not. Run `kubeone config print --full` for details on how to use this field

Documentation:

TBD

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Sep 20, 2022
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 20, 2022
@kron4eg
New Features.NodeLocalDNS API field
b96e82b 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Conditionally deploy NodeLocalDNS
1aa03e8 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg kron4eg marked this pull request as ready for review September 20, 2022 16:24
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 20, 2022
@xmudrii xmudrii self-assigned this Sep 20, 2022
xmudrii
xmudrii requested changes Sep 21, 2022
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

machine-controller and OSM addons are using the NodeLocalDNS IP address. We need to adjust those addons as well.

@kron4eg
NodeLocalDNS.Deploy regulates -cluster-dns flag for MC and OSM
89e0acf 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Copy link
Member Author

kron4eg commented Sep 21, 2022

@xmudrii good catch. Fixed.

xmudrii
xmudrii approved these changes Sep 21, 2022
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 21, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e2a788ef001dfec7bc49e2298bda8d7613199f70

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2022
@kubermatic-bot kubermatic-bot merged commit 1b004c0 into kubermatic:master Sep 21, 2022
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.6 milestone Sep 21, 2022
@kron4eg kron4eg deleted the node-local-dns-api branch September 21, 2022 15:43
@xmudrii
Copy link
Member

xmudrii commented Sep 26, 2022

/cherrypick release/v1.5

@kubermatic-bot kubermatic-bot mentioned this pull request Sep 26, 2022
Merged
@kubermatic-bot
Copy link
Contributor

@xmudrii: new pull request created: #2377

In response to this:

/cherrypick release/v1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added the docs/tbd Denotes a PR that needs documentation (change) that will be done later. label Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/tbd Denotes a PR that needs documentation (change) that will be done later. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.6
Development

Successfully merging this pull request may close these issues.

Add an Option to disable Nodelocal DNS Cache setup
3 participants
@kron4eg @kubermatic-bot @xmudrii