Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set iptables backend to NFT for Canal and Calico VXLAN on Flatcar clusters #2301

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Aug 22, 2022

What this PR does / why we need it:

It happens that after upgrading Canal/Calico to a newer minor version, the pod network connectivity stops working for some reason. This mostly happens on Flatcar-based clusters and not always, but from time to time. This is a known upstream Calico issue and it's being tracked here: projectcalico/calico#5760

As mentioned in projectcalico/calico#5760 (comment), the solution is to set FELIX_IPTABLESBACKEND to NFT.

If there's a Flatcar control plane node in the cluster, KubeOne will set FELIX_IPTABLESBACKEND to NFT. Otherwise, KubeOne will set FELIX_IPTABLESBACKEND to Auto, which is the current default value and results in Calico automatically determining the iptables backend.

This can be overridden by setting the iptablesBackend parameter on Canal or Calico VXLAN addon. For example:

apiVersion: kubeone.k8c.io/v1beta2
kind: KubeOneCluster
...
addons:
  enable: true
  addons:
    - name: cni-canal # or calico-vxlan if cluster is running Calico VXLAN
      params:
        iptablesBackend: "Auto"

This might also affect RHEL, but from our testing, it's much less frequent than for Flatcar. To reduce the scope of changes before the release, we'll revisit this after releasing KubeOne 1.5.

What type of PR is this?

/kind bug

Does this PR introduce a user-facing change? Then add your Release Note here:

Set iptables backend (`FELIX_IPTABLESBACKEND`) to `NFT` for Canal and Calico VXLAN on clusters running Flatcar Linux. For non Flatcar clusters, iptables backend is set to Auto, which is the default value and results in Calico determining the iptables backend automatically. The value can be overridden by setting the `iptablesBackend` addon parameter (see the PR description for an example).

Documentation:

NONE

…sters

Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Aug 22, 2022
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 22, 2022
@xmudrii xmudrii marked this pull request as ready for review August 22, 2022 12:22
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 22, 2022
@xmudrii
Copy link
Member Author

xmudrii commented Aug 22, 2022

/retest

@rastislavs
Copy link
Contributor

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 14cb46982cce48c5032a6e31dbd10888284c91b0

@xmudrii xmudrii added this to the KubeOne 1.5 milestone Aug 22, 2022
Copy link
Member

@moadqassem moadqassem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: moadqassem

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 22, 2022
@kubermatic-bot kubermatic-bot merged commit 99f5ce1 into master Aug 22, 2022
@kubermatic-bot kubermatic-bot deleted the flatcar-nft branch August 22, 2022 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants