Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark install and upgrade subcommands deprecated #2258

Merged
merged 1 commit into from
Aug 8, 2022
Merged

Mark install and upgrade subcommands deprecated #2258

merged 1 commit into from
Aug 8, 2022

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Aug 8, 2022 •
edited
Loading

What type of PR is this?
/kind cleanup
/kind deprecation

What this PR does / why we need it:
We had kubeone apply since long time, and nowadays even started to use it in e2e tests.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[ACTION REQUIRED] We announced with the KubeOne 1.4.0 release that kubeone install and kubeone upgrade commands are deprecated in favor of kubeone apply. This time we're marking those commands as hidden, so they'll not show in the help output. In the next release, we'll completely remove those commands, so we strongly recommend migrating to kubeone apply as soon as possible.

@kubermatic-bot kubermatic-bot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. labels Aug 8, 2022
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kron4eg kron4eg requested a review from xmudrii August 8, 2022 08:39
@kubermatic-bot kubermatic-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 8, 2022
@xmudrii
Copy link
Member

xmudrii commented Aug 8, 2022

@kron4eg Let's make this an action required release note. WDYT about something like this:

[ACTION REQUIRED] We announced with the KubeOne 1.4.0 release that kubeone install and kubeone upgrade commands are deprecated in favor of kubeone apply. This time we're marking those commands as hidden, so they'll not show in the help output. In the next release, we'll completely remove those commands, so we strongly recommend migrating to kubeone apply as soon as possible.

@kubermatic-bot kubermatic-bot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 8, 2022
@kron4eg
Copy link
Member Author

kron4eg commented Aug 8, 2022

@xmudrii sounds good, updated!

@kron4eg kron4eg marked this pull request as ready for review August 8, 2022 11:43
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 8, 2022
@kron4eg
Copy link
Member Author

kron4eg commented Aug 8, 2022

/retest

xmudrii
xmudrii reviewed Aug 8, 2022
View reviewed changes
pkg/cmd/install.go Outdated Show resolved Hide resolved
@kron4eg
Mark install and upgrade subcommands deprecated
f3867a0 
And hide them from help output.

Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg kron4eg force-pushed the install-upgrade-deprecate branch from 9eda791 to f3867a0 Compare August 8, 2022 13:26
@kubermatic-bot kubermatic-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 8, 2022
xmudrii
xmudrii approved these changes Aug 8, 2022
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ce80cf642c2cf47fcfd47afd48080833017db35b

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2022
@xmudrii xmudrii added this to the KubeOne 1.5 milestone Aug 8, 2022
@kubermatic-bot kubermatic-bot merged commit 354f50c into kubermatic:master Aug 8, 2022
@kron4eg kron4eg deleted the install-upgrade-deprecate branch August 8, 2022 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. lgtm Indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.5
Development

Successfully merging this pull request may close these issues.
3 participants
@kron4eg @kubermatic-bot @xmudrii