Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/v1.4] Use --max-pods flag instead of kubelet config file #2128

Merged
merged 1 commit into from
Jul 1, 2022
Merged

[release/v1.4] Use --max-pods flag instead of kubelet config file #2128

merged 1 commit into from
Jul 1, 2022

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented Jul 1, 2022

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR is a manual cherry-pick of #2112 and #2123.

Does this PR introduce a user-facing change?:

Fix wrong maxPods value on follower control plane nodes and static worker nodes

@xmudrii
Use --max-pods flag instead of kubelet config file
a0f0844 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii requested a review from kron4eg July 1, 2022 10:23
@kubermatic-bot kubermatic-bot added kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jul 1, 2022
@xmudrii xmudrii changed the title Use --max-pods flag instead of kubelet config file [release/v1.4] Use --max-pods flag instead of kubelet config file Jul 1, 2022
@kubermatic-bot kubermatic-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 1, 2022
@kron4eg
Copy link
Member

kron4eg commented Jul 1, 2022

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2022
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5911c34b5877caac6c28da7f3fa649c2e1ae5f45

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2022
@xmudrii
Copy link
Member Author

xmudrii commented Jul 1, 2022

/retest

@kubermatic-bot kubermatic-bot merged commit aff2139 into release/v1.4 Jul 1, 2022
@kubermatic-bot kubermatic-bot deleted the cp-maxpods branch July 1, 2022 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg Awaiting requested review from kron4eg

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xmudrii @kron4eg @kubermatic-bot