Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node-role.kubernetes.io/control-plane taint to nodes running Kubernetes 1.24 #2019

Merged
merged 3 commits into from
May 5, 2022

Conversation

xmudrii
Copy link
Member

@xmudrii xmudrii commented May 5, 2022

What type of PR is this?

/kind feature

What this PR does / why we need it:

Automatically apply the node-role.kubernetes.io/control-plane taint to nodes running Kubernetes 1.24. The taint is also supposed to be applied when nodes are upgraded from 1.23 to 1.24. This might require customers to adjust their workloads to tolerate the new taint before upgrading. This is now matching the behavior of kubeadm.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #2010

Does this PR introduce a user-facing change?:

[ACTION REQUIRED] Automatically apply the `node-role.kubernetes.io/control-plane` taint to nodes running Kubernetes 1.24. The taint is also applied when upgrading nodes from Kubernetes 1.23 to 1.24. You might need to adjust your workloads to tolerate the `node-role.kubernetes.io/control-plane` taint (in addition to the `node-role.kubernetes.io/master` taint). Workloads deployed by KubeOne will be adjusted automatically.

/assign @kron4eg

xmudrii added 2 commits May 5, 2022 10:19
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@xmudrii xmudrii requested a review from kron4eg May 5, 2022 08:24
@kubermatic-bot kubermatic-bot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. kind/feature Categorizes issue or PR as related to a new feature. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 5, 2022
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
@kron4eg
Copy link
Member

kron4eg commented May 5, 2022

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 78f3b0ba9fb760f7c863403ea0b4bd64d5a94027

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2022
@kubermatic-bot kubermatic-bot merged commit 4cd3ec3 into master May 5, 2022
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.5 milestone May 5, 2022
@kubermatic-bot kubermatic-bot deleted the control-plane-taint branch May 5, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants