Update secret name for backup-restic addon to backup-restic-s3-credentials

[ahmedwaleedmalik]

Signed-off-by: Waleed Malik ahmedwaleedmalik@gmail.com

What type of PR is this?

/kind cleanup

What this PR does / why we need it:
Currently, there is a conflict between the s3-credentials secret created by KKP and KubeOne. Both use the same secret name and deploy it in the same namespace i.e. kube-system. But the keys within the secret are different for both of them.

In a bid to solve this issue, we are renaming the secret in KubeOne.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

[ACTION REQUIRED] Update secret name for backup-restic addon to kubeone-backups-credentials. Manual migration steps are needed for users running KKP on top of a KubeOne installation and using both backup-restic addon from KubeOne and s3-exporter from KKP. Ensure that the `s3-credentials` Secret with keys `ACCESS_KEY_ID` and `SECRET_ACCESS_KEY` exists in `kube-system` namespace and doesn't have the label `kubeone.io/addon:`. Remove the label if it exists. Else s3-exporter won't be functional.

[kubermatic-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmedwaleedmalik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahmedwaleedmalik]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[xmudrii]

@ahmedwaleedmalik Can you please add [ACTION REQUIRED] release note and mention that users using both this addon and s3-exporter should take additional steps?

[ahmedwaleedmalik]

@xmudrii Do they really have to? As in when they'll update kubeone, the new dedicated secret will be used for this addon. And the de-coupling would be removed.

Same will happen if they update KKP first.

[ahmedwaleedmalik]

Are you talking about the case where a K1 update would prune/remove the existing s3-credentials?

[xmudrii]

@ahmedwaleedmalik Yes, I was talking about pruning the s3-credentials Secret.

[ahmedwaleedmalik]

/retest

[kubermatic-bot]

LGTM label has been added.

Git tree hash: e6ec3b2301be4bd432b420b5be659aa0ce10aa63