Use semver constraints on Kubernetes version for upper and lower bounds #1808
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
kubermatic-bot
added
release-note
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
kubermatic-bot
added
the
do-not-merge/work-in-progress
kron4eg
reviewed
Feb 4, 2022
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
|
/test pull-kubeone-lint |
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
kubermatic-bot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
|
/retest |
kron4eg
approved these changes
Feb 7, 2022
|
LGTM label has been added. Git tree hash: 774d3e80b73f2e5f0da5085d6e7910241dfbc150
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik, kron4eg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
|
I'm not sure, most likely no since that would be an unexpected novelty in 1.3. |
|
I agree with @kron4eg, it's unexpected in a patch release for 1.3. IMHO it should not be cherry-picked. It's "just" codifying the "contract" we already have in place through the support documentation. |
embik
added a commit
to embik/kubeone
that referenced
this pull request
Feb 8, 2022
…ds (kubermatic#1808) * Use semver constraints on Kubernetes version for upper and lower bounds Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Fix linting issues Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Improve constraint usage and correctly append errors Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Use mustParseConstraint Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Fix test case Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Appease linter Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
kubermatic-bot
pushed a commit
that referenced
this pull request
Feb 8, 2022
… and lower bounds (#1817) * Use semver constraints on Kubernetes version for upper and lower bounds (#1808) * Use semver constraints on Kubernetes version for upper and lower bounds Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Fix linting issues Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Improve constraint usage and correctly append errors Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Use mustParseConstraint Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Fix test case Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Appease linter Signed-off-by: Marvin Beckers <marvin@kubermatic.com> * Adjust version constraints to v1.3 branch Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This adds validation against two semver constraints that can easily be bumped from the top of the file when adding new Kubernetes versions.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1807
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Signed-off-by: Marvin Beckers marvin@kubermatic.com