Small CSR tweaks #1758
Merged
Small CSR tweaks #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Artiom Diomin <kron82@gmail.com>
Signed-off-by: Artiom Diomin <kron82@gmail.com>
kubermatic-bot
added
release-note-none
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahmedwaleedmalik, kron4eg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
xmudrii
reviewed
Jan 27, 2022
| @@ -235,26 +234,26 @@ func approvePendingCSR(s *state.State, node *kubeoneapi.HostConfig, conn ssh.Con | |||
|
|
|||
| func validateCSR(spec certificatesv1.CertificateSigningRequestSpec, node *kubeoneapi.HostConfig) error { | |||
| if fmt.Sprintf("%s:%s", nodeUser, node.Hostname) != spec.Username { | |||
| return errors.New("") | |||
| return fmt.Errorf("CSR username %q and node hostname %q do not match", spec.Username, node.Hostname) | |||
There was a problem hiding this comment.
I guess this should be errors.New instead.
There was a problem hiding this comment.
I like Errorf better since it manifests that "format" is used
There was a problem hiding this comment.
There’s also Errorf in the errors package, so we get to use same package everywhere. Just a nit though.
|
/lgtm cancel |
xmudrii
approved these changes
Jan 27, 2022
|
LGTM label has been added. Git tree hash: cb646696cfcd61e47f3dfa460e50b2a3bea2d717
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Addressing some review comments from #1750 (review)
Does this PR introduce a user-facing change?: