-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nutanix CSI snapshot controller addon #1734
Conversation
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We do not deploy the snapshot controller for other CSI addons (Azure, AWS) as separate addons but embed it into the CSI driver addon, why is this handled differently? |
LGTM label has been added. Git tree hash: 2947767199b03d9deff039bd684213566f135348
|
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
We tend to organize addons in the same way as the vendor. In this concrete case, Nutanix provides the CSI driver and the snapshot controller as two separate Helm charts, therefore we have two addons. This makes maintaining, upgrading, and keeping addons in sync easier. Technically, it doesn't matter much, besides the fact that users will have to enable two addons if they want to use both. |
/hold |
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
/hold cancel |
LGTM label has been added. Git tree hash: 500d626825ddfe5303e7b2a9a645812ee8b40f46
|
What this PR does / why we need it:
This PR extends the Nutanix CSI driver addon to add the snapshot controller. The rest of the description explains how to test the snapshot controller.
Once the cluster is provisioned, create a VolumeSnapshotClass:
After that, create a PVC and a pod that will use it:
Exec to the
nginx
pod and write some files in the/var/lib/www/html
directory. After that, snapshot the volume:Wait for the snapshot to be complete, and then remove the PVC and the pod. Wait a while, and then create a new PVC that uses the snapshot:
Exec to the pod and check are the files you created earlier present.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1726
Does this PR introduce a user-facing change?:
/assign @kron4eg