-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for OpenStack application credentials and update validation #1666
Add support for OpenStack application credentials and update validation #1666
Conversation
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
/test pull-kubeone-e2e-openstack-conformance-1.22 |
Co-authored-by: Marko Mudrinić <mudrinic.mare@gmail.com>
/test pull-kubeone-e2e-openstack-conformance-1.22 |
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
/test pull-kubeone-e2e-openstack-conformance-1.22 |
LGTM label has been added. Git tree hash: c946fe2790e2b52f1f642e48ab88fd15defcb7d0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: embik, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
machine-controller supports OpenStack application credentials since kubermatic/machine-controller#900. This PR adds support for picking that up and passing it as part of the credentials secret.
It also adjusts the validation function for OpenStack to make sure we're not passing both application and user credentials at the same time.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1659
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Signed-off-by: Marvin Beckers marvin@kubermatic.com