Add support for external cloud provider #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows for cloud provider without in-tree implementation to be specified in provider.Name, so worker nodes can be created automatically from Terraform output. This also allows external to be specified as provider.Name.
kubermatic-bot
added
release-note
|
/assign @kron4eg |
|
/lgtm |
|
LGTM label has been added. Git tree hash: 59be6940f5cac4e7572a7fce173abb08fb52040a
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kron4eg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubermatic-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR brings the following changes:
provider.Nameto other providers such as DigitalOcean or Hetzner (instead of specifying nothing). This way we know on what cloud we deploy and can use Terraform automation for workers.external, which configures cluster to work with external CCMThere are several problems with this PR:
externalit is up to user's responsibility to deploy external CCM (this is expected behavior)external, we lose information about on what cloud provider we deploy on and can't use automation (this is unexpected behavior)As @kron4eg tested this already and it works well, I'm proposing to merge this PR and then create follow-up issues and PRs.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #117
Release note: