Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MachineAnnotations for DynamicWorkerConfig #1601

Merged
merged 1 commit into from
Oct 29, 2021
Merged

MachineAnnotations for DynamicWorkerConfig #1601

merged 1 commit into from
Oct 29, 2021

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Oct 28, 2021

What this PR does / why we need it:

Fixes #1591

Copy annotations to initial MachineDeployment.Spec.Template.Spec.Annotations

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Oct 28, 2021
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 28, 2021
@xmudrii
Copy link
Member

xmudrii commented Oct 28, 2021

/hold

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2021
@xmudrii xmudrii self-assigned this Oct 28, 2021
@kron4eg
MachineAnnotations for DynamicWorkerConfig
91149c2 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kubermatic-bot kubermatic-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 28, 2021
@kron4eg kron4eg changed the title Copy annotations to initial MachineDeployment.Spec.Template.Spec.Annotations MachineAnnotations for DynamicWorkerConfig Oct 28, 2021
@kron4eg
Copy link
Member Author

kron4eg commented Oct 29, 2021

@xmudrii what's holding?

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b25c00ccc1510874059f5bd7f2e767d01e0fe5da

@xmudrii
Copy link
Member

xmudrii commented Oct 29, 2021

/hold cancel

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 29, 2021
@kubermatic-bot kubermatic-bot merged commit 4dbfa40 into kubermatic:master Oct 29, 2021
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.4 milestone Oct 29, 2021
@kron4eg kron4eg deleted the md-annotations-copy branch October 30, 2021 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@embik embik embik left review comments

@xmudrii xmudrii xmudrii approved these changes

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.4
Development

Successfully merging this pull request may close these issues.

Annotations are not applied to node while defining dynamic workers
4 participants
@kron4eg @kubermatic-bot @xmudrii @embik