Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update machinecontroller and gce example #1576

Merged
merged 3 commits into from
Oct 20, 2021
Merged

Update machinecontroller and gce example #1576

merged 3 commits into from
Oct 20, 2021

Conversation

mate4st
Copy link
Contributor

@mate4st mate4st commented Oct 12, 2021 •
edited
Loading

What this PR does / why we need it:
Updates machinecontroller that uses newer OS images for provisioning.

* Update machine-controller to v1.36.0. machine-controller is now using Ubuntu 20.04 instead of 18.04 by default for all newly-created Machines on   AWS, Azure, DO, GCE, Hetzner, Openstack and Equinix Metal 
* [BREAKING] Example Terraform config for GCP is now using Ubuntu 20.04 by default. Make sure to bind control_plane_image_family to the image you're currently using or Terraform might recreate all your control plane instances.

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Oct 12, 2021
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: WeirdMachine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mate4st mate4st requested a review from xmudrii October 12, 2021 15:24
@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 12, 2021
@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 12, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 500e36017076c617c7ed73b03d07363dbbd597b6

@kron4eg
Copy link
Member

kron4eg commented Oct 12, 2021

/retest

1 similar comment
@kron4eg
Copy link
Member

kron4eg commented Oct 12, 2021

/retest

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

@mate4st
Copy link
Contributor Author

mate4st commented Oct 12, 2021

/hold

@kubermatic-bot kubermatic-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 12, 2021
@mate4st
Copy link
Contributor Author

mate4st commented Oct 13, 2021

/test pull-kubeone-e2e-aws-flatcar-containerd-conformance-1.19

@kubermatic-bot kubermatic-bot removed the lgtm Indicates that a PR is ready to be merged. label Oct 13, 2021
@kubermatic-bot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@mate4st mate4st added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2021
@mate4st
Copy link
Contributor Author

mate4st commented Oct 20, 2021

/unhold

@kubermatic-bot kubermatic-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 20, 2021
@kubermatic-bot kubermatic-bot merged commit b8e4cf5 into kubermatic:master Oct 20, 2021
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.4 milestone Oct 20, 2021
@mate4st mate4st deleted the updates branch October 21, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

@xmudrii xmudrii Awaiting requested review from xmudrii

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@mate4st @kubermatic-bot @kron4eg @kubermatic-triage-bot