Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Addon api #1486

Merged
merged 5 commits into from
Sep 3, 2021
Merged

Enable Addon api #1486

merged 5 commits into from
Sep 3, 2021

Conversation

mate4st
Copy link
Contributor

@mate4st mate4st commented Sep 2, 2021 •
edited
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #1459

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 2, 2021
@mate4st mate4st requested a review from xmudrii September 2, 2021 20:26
@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Sep 2, 2021
@mate4st mate4st changed the title Addon api Enable Addon api Sep 2, 2021
@kubermatic-bot kubermatic-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 3, 2021
kron4eg
kron4eg reviewed Sep 3, 2021
View reviewed changes
pkg/addons/applier.go Outdated Show resolved Hide resolved
@mate4st @kron4eg
Ignore not found errors when deleteing addons
79af53c 
Co-authored-by: Artiom Diomin <artiom@hey.com>
@kubermatic-bot kubermatic-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 3, 2021
@xmudrii
Make backups-restic addon use params and update example config
d751b26 
Signed-off-by: Marko Mudrinić <mudrinic.mare@gmail.com>
xmudrii
xmudrii reviewed Sep 3, 2021
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @weirdmachine! 💯

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8db7103f658e511ca4aa67358af25ff08d6e999f

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: WeirdMachine, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [WeirdMachine,xmudrii]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot merged commit 8c178cc into kubermatic:master Sep 3, 2021
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.3 milestone Sep 3, 2021
@mate4st mate4st deleted the addong-api branch October 21, 2022 21:38
@embik embik mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg left review comments

@xmudrii xmudrii xmudrii left review comments

Assignees

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.3
Development

Successfully merging this pull request may close these issues.
4 participants
@mate4st @kubermatic-bot @kron4eg @xmudrii