Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New Addons API #1462

Merged
merged 4 commits into from
Sep 2, 2021
Merged

New Addons API #1462

merged 4 commits into from
Sep 2, 2021

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Aug 19, 2021 •
edited by xmudrii
Loading

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
xref #1459

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

New Addons API

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Aug 19, 2021
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added the dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. label Aug 19, 2021
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 19, 2021
@kron4eg kron4eg force-pushed the addons-api branch 7 times, most recently from dc82c6f to 9ac7add Compare August 26, 2021 12:14
@xmudrii
Copy link
Member

xmudrii commented Aug 27, 2021

/test pull-kubeone-build

@kron4eg kron4eg force-pushed the addons-api branch 5 times, most recently from 5e840cd to ed1eff2 Compare August 30, 2021 12:22
@kron4eg kron4eg marked this pull request as ready for review August 30, 2021 12:27
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 30, 2021
@kron4eg kron4eg requested a review from xmudrii August 30, 2021 12:27
xmudrii
xmudrii reviewed Aug 30, 2021
View reviewed changes
pkg/addons/manifest_test.go
@@ -198,7 +198,7 @@ func TestEnsureAddonsLabelsOnResources(t *testing.T) {
LocalFS: os.DirFS(addonsDir),
}

manifests, err := applier.loadAddonsManifests(applier.LocalFS, ".", nil, false, "")
manifests, err := applier.loadAddonsManifests(applier.LocalFS, ".", nil, nil, false, "")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if we would have a test case to test manifest parsing when a map is provided.

pkg/apis/kubeone/v1beta1/types.go Outdated
Comment on lines 601 to 602
// Delete flag to ensure the named addon with all its contents to be deleted
Delete bool `json:"deleted,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this Delete implemented at all?

pkg/apis/kubeone/v1beta1/types.go
GlobalParams map[string]string `json:"globalParams,omitempty"`

// Addons is a list of config options for named addon
Addons []Addon `json:"addons,omitempty"`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you implemented enabling embedded addons via this API yet?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, this is out of scope.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually the key part of the Epic. Passing parameters to addons was supposed to be only a nice addition if we have time left, but not the key part. Quoting part of the Epic description:

We need to implement an API that can be used to enable optional addons embedded in the binary, such as cluster-autoscaler and unattended-upgrades.

Can you please extend the PR to handle this as well? I think it should be fairly easy, but it might take some time to test it properly.

@kron4eg kron4eg marked this pull request as draft August 31, 2021 08:36
@kubermatic-bot kubermatic-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 31, 2021
@kron4eg kron4eg force-pushed the addons-api branch 2 times, most recently from 024a56f to 2534496 Compare September 1, 2021 09:14
@kron4eg
Addons API
d5ca4ed 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Addons params
5675cd7 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Fix codegen
28ef1c8 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@kron4eg
Fix json tag
997adbd 
Signed-off-by: Artiom Diomin <kron82@gmail.com>
@xmudrii xmudrii marked this pull request as ready for review September 2, 2021 08:47
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 2, 2021
@mate4st
Copy link
Contributor

mate4st commented Sep 2, 2021

/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 2, 2021
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 7a109b4ef3c20357ce04056b1caa09a9e84e59ec

@kubermatic-triage-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

@kubermatic-bot
Copy link
Contributor

@kubermatic-triage-bot: cat image

In response to this:

/retest
This bot automatically retries jobs that failed/flaked on approved PRs

Review the full test history

Silence the bot with an /lgtm cancel or /hold comment for consistent failures.

Also, here is a cat.
/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot merged commit 4d8ff7a into kubermatic:master Sep 2, 2021
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.3 milestone Sep 2, 2021
@kron4eg kron4eg deleted the addons-api branch September 3, 2021 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii left review comments

Assignees

@xmudrii xmudrii

@mate4st mate4st

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.3
Development

Successfully merging this pull request may close these issues.
5 participants
@kron4eg @kubermatic-bot @xmudrii @mate4st @kubermatic-triage-bot