Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update calico to v3.16.5 #1163

Merged
merged 2 commits into from
Nov 23, 2020
Merged

Update calico to v3.16.5 #1163

merged 2 commits into from
Nov 23, 2020

Conversation

maxilampert
Copy link
Contributor

What this PR does / why we need it:

Update calico to v3.16.5 including eBPF mode pre-requirements

Special notes for your reviewer:
I added the pre-requirements for eBPF as it is GA with v3.16, if its is not desired in kubeone let me know and I will remove it

Does this PR introduce a user-facing change?:

Update calico to v3.16.5

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 16, 2020
@kubermatic-bot
Copy link
Contributor

Hi @maxilampert. Thanks for your PR.

I'm waiting for a kubermatic member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kubermatic-bot kubermatic-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 16, 2020
@maxilampert
Update calico to v3.16.5 including eBPF mode pre-requirements
bf0b680 
Signed-off-by: Maximilian Lampert <ml@mlampert.de>
@maxilampert maxilampert force-pushed the feature/canal-v3.16.5 branch from 15134c6 to bf0b680 Compare November 16, 2020 23:05
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. and removed dco-signoff: no Denotes that at least one commit in the pull request doesn't have a valid DCO signoff message. labels Nov 16, 2020
@maxilampert
Remove beta label
cead434 
Signed-off-by: Maximilian Lampert <ml@mlampert.de>
@kron4eg
Copy link
Member

kron4eg commented Nov 23, 2020

/ok-to-test

@kubermatic-bot kubermatic-bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 23, 2020
@kron4eg
Copy link
Member

kron4eg commented Nov 23, 2020

/retest

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Nov 23, 2020
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 643e8fa14cef4aa74b532e7d413bbb12f0b9fb74

@kron4eg
Copy link
Member

kron4eg commented Nov 23, 2020

/approve

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg, maxilampert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 23, 2020
@kubermatic-bot kubermatic-bot merged commit ec0e690 into kubermatic:master Nov 23, 2020
@xmudrii xmudrii mentioned this pull request Dec 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg kron4eg approved these changes

Assignees

@kron4eg kron4eg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxilampert @kubermatic-bot @kron4eg