fix: avoid defining function based on alias errors

[luisdavim]

If users already have some aliases defined that collide with any of the functions defined here (if they for example also use https://github.com/ahmetb/kubectl-aliases) they will get an error saying "defining function based on alias" prefixing the function declarations with function will avoid this.

Signed-off-by: Luis Davim luis.davim@sendoso.com

[ievgenii-shepeliuk]

@luisdavim you should assign a person as kubermatic-bot suggest in the message above
to make a progress with the PR

[luisdavim]

/assign @toschneck

[kron4eg]

@luisdavim

prefixing the function declarations with function will avoid this.

What will happen instead? Original aliases would be overridden? Also, I can't reproduce this in my bash.

[luisdavim]

At least in zsh you get an error message saying that the function is based on an alias. It expands the alias before interpreting the function and fails.
This change solves that and ir should be compatible with both bash and zsh.

[luisdavim]

If you google for "function based on alias error", you'll find various similar cases in other projects that were also solved like this.

[kron4eg]

/approve

[kubermatic-bot]

LGTM label has been added.

Git tree hash: f8f9f17d0212613b2a0cad98957cc24f518015d0

[kubermatic-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg, luisdavim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kron4eg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kron4eg]

@luisdavim thanks for your contribution!