Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct example syntax for backups-restic addon in KubeOne #1591

Merged

Conversation

embik
Copy link
Member

@embik embik commented Dec 14, 2023

As per kubermatic/kubeone#2981, the backups-restic addon was incorrectly documented. This updates the existing documentation as per the current behaviour, as changing it would be a breaking change.

Signed-off-by: Marvin Beckers <marvin@kubermatic.com>
@embik embik self-assigned this Dec 14, 2023
@kubermatic-bot kubermatic-bot added dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 14, 2023
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 14, 2023
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3ea4f36ce4e92a8cc08685370b3cb34b5188b536

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2023
@kubermatic-bot kubermatic-bot merged commit 2a0c09f into kubermatic:master Dec 14, 2023
11 checks passed
@embik embik deleted the kubeone-backup-addon-correct-params branch December 15, 2023 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants