Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove redundant policy route addition in node handling #4835

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

oilbeater
Copy link
Collaborator

Pull Request

What type of this PR

Examples of user facing changes:

  • Performance

Which issue(s) this PR fixes

Subnet handler will sync route policies, no need to add it here. This can partially solve the issue mentioned in #4822.

Signed-off-by: oilbeater <liumengxinfly@gmail.com>
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. performance Anything that can make Kube-OVN faster labels Dec 16, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12350565019

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 22.083%

Totals Coverage Status
Change from base Build 12347800600: 0.002%
Covered Lines: 10267
Relevant Lines: 46493

💛 - Coveralls

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 16, 2024
@oilbeater oilbeater merged commit 6c109a9 into master Dec 17, 2024
68 checks passed
@oilbeater oilbeater deleted the perf/route-policy branch December 17, 2024 01:41
oilbeater added a commit that referenced this pull request Dec 17, 2024
)

Signed-off-by: oilbeater <liumengxinfly@gmail.com>
oilbeater added a commit that referenced this pull request Dec 17, 2024
)

Signed-off-by: oilbeater <liumengxinfly@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer performance Anything that can make Kube-OVN faster size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants