Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix subnet finalizer #3004

Merged
merged 1 commit into from
Jul 3, 2023
Merged

fix subnet finalizer #3004

merged 1 commit into from
Jul 3, 2023

Conversation

zhangzujian
Copy link
Member

@zhangzujian zhangzujian commented Jul 2, 2023

What type of this PR

  • Bug fixes

Which issue(s) this PR fixes:

Fixes #(issue-number)

WHAT

🤖 Generated by Copilot at d885619

Fix a logical bug in subnet.go that could cause a premature removal of the subnet finalizer. This change ensures the proper cleanup of subnet resources.

🤖 Generated by Copilot at d885619

Subnet finalizer
Fixed with parentheses and
No more autumn leaks

HOW

🤖 Generated by Copilot at d885619

  • Fix the logical condition for removing the finalizer from the subnet object (link)

@zhangzujian zhangzujian added the bug Something isn't working label Jul 2, 2023
@zhangzujian zhangzujian requested a review from changluyi July 3, 2023 01:02
@zhangzujian zhangzujian merged commit fe924e9 into kubeovn:master Jul 3, 2023
@zhangzujian zhangzujian deleted the fix-u2o branch July 3, 2023 03:10
zhangzujian added a commit that referenced this pull request Jul 3, 2023
zhangzujian added a commit that referenced this pull request Jul 3, 2023
zhangzujian added a commit that referenced this pull request Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working need backport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants