Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubectl-ko: fix trace when u2oInterconnection is enabled #2836

Merged
merged 1 commit into from
May 24, 2023

Conversation

zhangzujian
Copy link
Member

What type of this PR

  • Bug fixes

Which issue(s) this PR fixes:

Fixes #(issue-number)

WHAT

copilot:summary

copilot:poem

HOW

copilot:walkthrough

@zhangzujian zhangzujian added bug Something isn't working need backport labels May 19, 2023
@github-actions
Copy link
Contributor

  • Priority 1: In line 306, the variable u2oIC is defined but not used. This can be removed to avoid confusion and unnecessary code.
  • Priority 2: In line 303, the condition checks for the value of $logicalGateway to be "true". However, in line 307, it also checks for the value of $u2oIC to be "true". This might cause unexpected behavior if both variables have conflicting values. It would be better to use a single condition that checks for both variables at once.
  • Priority 3: In line 358, the echo statement says "Using the gateway mac address as destination", but the code actually uses the logical gateway's MAC address. This can be confusing and should be updated to reflect the correct behavior.
  • Priority 4: In line 361, the variable $typedName is used without being defined. This might cause errors or unexpected behavior and should be fixed.
  • Priority 5: In line 365, the command tr -d '\r' is used to remove carriage return characters from the output of the ovn-nbctl command. This might not work on all systems and could cause issues. A more portable solution should be used instead.

@zhangzujian zhangzujian marked this pull request as ready for review May 19, 2023 10:15
@zhangzujian zhangzujian requested a review from oilbeater May 19, 2023 10:16
@oilbeater oilbeater requested a review from changluyi May 23, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working need backport
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants