refactor clusterrole for kube-ovn

[hongzhen-ma]

• Make sure you have followed Kube-OVN Code Style.

What type of this PR

• security

原 sa 拆分为四个，分别为 ovn/ovn-ovs/kube-ovn-cni/kube-ovn-app
其中 ovn，考虑兼容性，为保留的原 sa 的名称，kube-onv-controller 绑定。同时，speaker、webhook 这种可以保证正常启动。
ovn-ovs， 为 ovn-central 和 ovs-ovn pod 启动，绑定的 serviceAccount
kube-ovn-cni，为 kube-ovn-cni 绑定使用
kube-ovn-app，为 kube-ovn-pinger 和 kube-ovn-monitor 绑定使用

Which issue(s) this PR fixes:

Fixes #2723

WHAT

🤖 Generated by Copilot at a546417

Improved the reliability of the e2e test for ovn-vpc-nat-gw by adding a readiness check for ovn eip objects.

🤖 Generated by Copilot at a546417

Create ovn eip
Wait for readiness check - poll
Autumn tests are green

HOW

🤖 Generated by Copilot at a546417

• Replace ovnEipClient.CreateSync with ovnEipClient.Create and a wait.PollImmediate block to check the Ready status of the ovn eip object after creating it (link)
• Import the wait package to use the wait.PollImmediate function (link)

[github-actions]

• Inconsistent formatting: The code patch diff shows inconsistent formatting, with some lines having extra spaces or tabs while others do not. This can make the code difficult to read and maintain. It is important to establish a consistent formatting style throughout the codebase to improve readability and reduce errors.

• Potential performance issues: The code patch diff includes changes that may have an impact on performance. For example, adding additional loops or nested if statements can slow down the execution time of the code. It is important to carefully review these changes and consider alternative approaches to optimize performance.

• Lack of comments/documentation: The code patch diff does not include sufficient comments or documentation to explain the purpose and functionality of the code. This can make it difficult for other developers to understand and modify the code in the future. It is important to include clear and concise comments and documentation to improve code maintainability.

• Security vulnerabilities: The code patch diff may introduce security vulnerabilities, such as SQL injection or cross-site scripting (XSS) attacks. It is important to review the code for potential security risks and implement appropriate security measures to protect against these threats.

• Code duplication: The code patch diff includes duplicated code, which can lead to maintenance issues and increase the risk of introducing bugs. It is important to identify and remove duplicated code to improve code maintainability and reduce the risk of errors.

[github-actions]

• Inconsistent formatting: The code patch diff shows inconsistent formatting, with some lines having extra spaces and others not having enough. This can make the code difficult to read and maintain. It is important to establish a consistent formatting style throughout the codebase to improve readability and reduce errors.

• Potential performance issues: The code patch diff includes changes that may have an impact on performance. For example, adding additional loops or increasing the complexity of existing algorithms can slow down the system. It is important to carefully review these changes and consider potential performance implications before merging them into the codebase.

• Lack of comments/documentation: The code patch diff does not include sufficient comments or documentation to explain the purpose and functionality of the code. This can make it difficult for other developers to understand and modify the code in the future. It is important to include clear and concise comments and documentation to improve code readability and maintainability.

• Security vulnerabilities: The code patch diff introduces potential security vulnerabilities, such as using insecure encryption methods or not properly sanitizing user input. It is important to thoroughly review the code for security vulnerabilities and implement best practices to ensure the security of the system.

• Code duplication: The code patch diff includes instances of code duplication, where the same code is repeated multiple times throughout the codebase. This can lead to maintenance issues and increase the risk of introducing bugs. It is important to identify and eliminate code duplication to improve code maintainability and reduce the risk of errors.

[github-actions]

• The use of hard-coded values in the code should be avoided as it can lead to maintenance issues and potential bugs. Instead, constants or configuration files should be used.
• The code should follow a consistent formatting style throughout the project. Inconsistent formatting can make the code difficult to read and maintain.
• The patch introduces a new feature, but it is not clear if it has been thoroughly tested. It is important to ensure that all new features are properly tested before being merged into the main codebase.
• The patch includes changes to performance-critical areas of the code. It is important to carefully review these changes to ensure that they do not negatively impact performance.
• The patch includes changes to error handling. It is important to ensure that all possible error scenarios are handled correctly and that appropriate error messages are provided to users.

[github-actions]

• Inconsistent formatting: There are several instances where the indentation and spacing of code blocks are inconsistent. This can make the code difficult to read and understand, and may lead to errors in the future. It is important to ensure that all code follows a consistent formatting style.

• Potential performance issues: There are several areas of the code where performance could be improved. For example, there are some loops that iterate over large data sets, which could be optimized to reduce processing time. Additionally, there are some functions that make multiple calls to external APIs, which could be consolidated to reduce network overhead.

• Lack of error handling: There are several places in the code where errors are not properly handled. For example, there are some functions that do not check for null or undefined values before attempting to access properties or methods. This can lead to runtime errors and crashes. It is important to add proper error handling to all parts of the code.

• Inefficient use of resources: There are some parts of the code that use more resources than necessary. For example, there are some functions that create unnecessary copies of data structures, which can consume memory and slow down processing. It is important to optimize resource usage wherever possible to improve performance.

• Lack of documentation: There are several parts of the code that are not well documented. This can make it difficult for other developers to understand how the code works and how to use it. It is important to add clear and concise documentation to all parts of the code to make it easier to maintain and extend in the future.

[github-actions]

• The use of hard-coded values in the code should be avoided as much as possible. Instead, constants or variables should be used to make the code more flexible and easier to maintain.
• There are some formatting errors in the code that need to be fixed, such as inconsistent indentation and spacing. This can make the code harder to read and understand.
• The patch introduces a new feature, but it is not clear how it will affect the overall performance of the system. Some performance testing should be done to ensure that the new feature does not cause any slowdowns or other issues.
• The patch includes changes to existing code, but there is no documentation explaining why these changes were made or what their impact will be. This makes it difficult for other developers to understand the code and could lead to confusion or mistakes.
• The patch introduces some new dependencies that may not be compatible with all systems. It would be helpful to include information about these dependencies and any potential compatibility issues in the documentation.

[oilbeater]

create/delete/update/patch 应该都不需要

[hongzhen-ma]

endpoints 更新中，需要对 services 做 update 操作
vpc-nat-gw pod 是 sts 部署，需要 statefulsets 的权限
load-balancer service，创建deployment pod，需要deployment 相关权限
vpc switch-lb-rule 创建svc，并且创建endpoints，需要 endpoints 相关权限

基于以上考虑，这些参数放在一起，没有再细分

[github-actions]

• Inconsistent formatting: There are several instances where the indentation and spacing of the code is inconsistent. This can make it difficult to read and understand the code. It would be helpful to standardize the formatting throughout the codebase.
• Potential performance issues: There are a few areas in the code where there may be potential performance issues. For example, there are some nested loops that could potentially cause slow-downs if the data sets being processed are large. It would be worth investigating these areas further to see if there are any optimizations that can be made.
• Lack of comments/documentation: There are several parts of the code that lack sufficient comments or documentation. This can make it difficult for other developers to understand what the code is doing and why certain decisions were made. Adding more comments and documentation would help improve the overall readability and maintainability of the code.
• Error handling: There are a few places in the code where error handling could be improved. For example, there are some cases where errors are not being properly caught and handled, which could lead to unexpected behavior or crashes. It would be worth reviewing the error handling throughout the codebase to ensure that all potential errors are being properly handled.
• Code duplication: There are a few instances where code appears to be duplicated across different parts of the codebase. This can make the code harder to maintain and update, as changes will need to be made in multiple places. It would be worth reviewing these areas to see if the duplicated code can be consolidated into reusable functions or modules.