clean up code about static routes #2779
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes:
Fixes #(issue-number)
WHAT
🤖 Generated by Copilot at 534bb67
This pull request refactors the
Controller
struct to remove the static routing logic for subnets with centralized gateways. This reduces the complexity and potential errors of the routing management inpkg/controller/controller.go
andpkg/controller/subnet.go
.🤖 Generated by Copilot at 534bb67
HOW
🤖 Generated by Copilot at 534bb67
deleteRouteQueue
field fromController
struct and its initialization and shutdown inRun
andshutdown
methods (link, link, link)runDeleteRouteWorker
method instartWorkers
method ofController
struct (link)deleteRouteQueue
inenqueueDeleteSubnet
method ofController
struct (link)runDeleteRouteWorker
method and its helper methodsprocessNextDeleteRoutePodWorkItem
andhandleDeleteRoute
fromsubnet.go
file (link, link, link)deleteStaticRoute
method inreconcileOvnDefaultVpcRoute
method ofController
struct (link)