Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When Subnet spec.vpc is updated, the status in VPC should also be updated #2756

Merged
merged 1 commit into from
May 6, 2023

Conversation

oilbeater
Copy link
Collaborator

@oilbeater oilbeater commented May 5, 2023

What type of this PR

Examples of user facing changes:

  • Bug fixes

There is still issues when change the vpc field, related lrp will not be deleted.

Which issue(s) this PR fixes:

Fixes #1190

WHAT

🤖 Generated by Copilot at 0426884

This pull request enhances the VPC and subnet controller logic and fixes some minor issues in the code and comments of vpc.go. It improves the handling of subnet VPC changes and the ecmp based bfd feature.

🤖 Generated by Copilot at 0426884

Sing, O Muse, of the skillful code review
That fixed the errors and improved the features
Of the subnet controller, the wise and true
Guardian of the VPC, the cloud's great teacher.

HOW

🤖 Generated by Copilot at 0426884

  • Add logic to handle subnet VPC changes (link, link)
  • Fix typos and improve naming in pkg/controller/vpc.go (link, link, link, link)

@oilbeater oilbeater added bug Something isn't working vpc labels May 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

  • In subnet.go, the function enqueueUpdateSubnet has been updated to add a check for changes in VPC. However, this check is also present in line 104. It would be better to remove the duplicate code and keep only one instance of the check.
  • In vpc.go, the function handleAddOrUpdateVpc has a typo in the log message on line 405. "connecte" should be "connect".
  • In vpc.go, the function handleAddOrUpdateVpc has another typo in the log message on line 452. "connecte" should be "connect".
  • In vpc.go, the function handleAddOrUpdateVpc has a typo in the log message on line 458. "connecte" should be "connect".
  • In vpc.go, the function handleAddOrUpdateVpc has a typo in the log message on line 407. "extrenalID" should be "externalID".

@oilbeater oilbeater requested a review from hongzhen-ma May 5, 2023 11:25
@oilbeater oilbeater merged commit 6db99d5 into master May 6, 2023
@oilbeater oilbeater deleted the fix/vpc-status branch May 6, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working vpc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

vpc updates failed for subnet
2 participants