Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For dualstack and ipv6 the default ipv6 range should be same with the… #2708

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

oilbeater
Copy link
Collaborator

@oilbeater oilbeater commented Apr 25, 2023

… ipv4 cidr.

What type of this PR

Examples of user facing changes:

  • Bug fixes

Which issue(s) this PR fixes:

Fixes #(issue-number)

WHAT

copilot:summary

copilot:poem

HOW

copilot:walkthrough

@oilbeater oilbeater requested a review from hongzhen-ma April 25, 2023 05:54
@github-actions
Copy link
Contributor

  • The commit message should provide more information about the changes made in the patch.
  • In the values.yaml file, the POD_CIDR, JOIN_CIDR, and SVC_CIDR values for ipv6 and dual_stack have been changed from /64 to /112. This change is necessary as /64 is too large for a single subnet and can cause issues with routing. However, it's important to ensure that these CIDRs do not overlap with each other or with any other networks in use.
  • In the install.sh script, the same changes have been made to the POD_CIDR, JOIN_CIDR, and SVC_CIDR values for ipv6 and dual_stack. Again, it's important to ensure that these CIDRs do not overlap with each other or with any other networks in use.
  • It's unclear why the PINGER_EXTERNAL_ADDRESS and PINGER_EXTERNAL_DOMAIN values have been changed in both files. If this change is necessary, it should be explained in the commit message.
  • The SVC_YAML_IPFAMILYPOLICY variable has been added to the install.sh script for dual-stack deployments. However, it's unclear what this variable does and how it affects the deployment. More information should be provided in the commit message or in comments within the script.

@oilbeater oilbeater merged commit 7dbfd2b into master Apr 25, 2023
@oilbeater oilbeater deleted the fix/ipv6-cidr branch April 25, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants