-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support dynamically changing qos for EIP #2671
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
could you please review this pr? @bobz965 @hongzhen-ma |
zbb88888
reviewed
Apr 19, 2023
zbb88888
reviewed
Apr 19, 2023
zbb88888
reviewed
Apr 19, 2023
zbb88888
reviewed
Apr 19, 2023
zbb88888
reviewed
Apr 19, 2023
zbb88888
reviewed
Apr 19, 2023
zbb88888
reviewed
Apr 19, 2023
shane965
force-pushed
the
feat-qos-policy
branch
from
April 19, 2023 11:27
b436e1e
to
8296b04
Compare
|
zbb88888
reviewed
Apr 20, 2023
zbb88888
reviewed
Apr 20, 2023
zbb88888
reviewed
Apr 20, 2023
zbb88888
reviewed
Apr 20, 2023
zbb88888
reviewed
Apr 20, 2023
zbb88888
reviewed
Apr 20, 2023
zbb88888
reviewed
Apr 20, 2023
zbb88888
reviewed
Apr 20, 2023
zbb88888
reviewed
Apr 20, 2023
|
zbb88888
approved these changes
Apr 20, 2023
The yamls in chart should also be updated |
|
|
|
hongzhen-ma
reviewed
Apr 21, 2023
|
hongzhen-ma
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes:
Fixes #2633
WHAT
🤖 Generated by Copilot at 54e9570
This pull request adds support for multiple QoS policy rules with different actions and match criteria, and improves the QoS policy deep copy, validation, and reconciliation logic. It also updates the QoSPolicy CRD and the QoS policy functions for EIPs to use the new QoS policy spec fields and types.
🤖 Generated by Copilot at 54e9570
HOW
🤖 Generated by Copilot at 54e9570
pkg/apis/kubeovn/v1/types.go
(link, link, link, link)pkg/apis/kubeovn/v1/zz_generated.deepcopy.go
(link, link, link)yamls/crd.yaml
(link, link, link)pkg/controller/qos_policy.go
(link)pkg/controller/qos_policy.go
(link, link, link, link, link, link, link, link)pkg/controller/vpc_nat_gw_eip.go
(link, link, link, link, link)