Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix LSP existence check #2657

Merged
merged 1 commit into from
Apr 17, 2023
Merged

fix LSP existence check #2657

merged 1 commit into from
Apr 17, 2023

Conversation

zhangzujian
Copy link
Member

@zhangzujian zhangzujian commented Apr 17, 2023

What type of this PR

  • Bug fixes

Which issue(s) this PR fixes:

Fixes #(issue-number)

WHAT

🤖 Generated by Copilot at b1a3ce1

Fix a logic error in reconcileOvnDefaultVpcRoute that caused missing default routes for some pods. This bug fix resolves issue #1140.

🤖 Generated by Copilot at b1a3ce1

reconcileOvn
Fixes logic error - kya!
Pods can surf now

HOW

🤖 Generated by Copilot at b1a3ce1

  • Fix logic error in reconcileOvnDefaultVpcRoute function to skip pods without lsp instead of with lsp (link)

@zhangzujian zhangzujian added the bug Something isn't working label Apr 17, 2023
@github-actions
Copy link
Contributor

  • The commit message is missing, please add a descriptive message explaining the changes made in this patch.
  • In line 1482, there is a typo "lsp" should be "LSP".
  • In line 1484, the error message should include the name of the pod that caused the error to make it easier for the user to identify which pod needs to be deleted.

@zhangzujian zhangzujian merged commit 05e7251 into kubeovn:master Apr 17, 2023
@zhangzujian zhangzujian deleted the fix-ovn-pg branch April 17, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants