Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix multus installation #2622

Merged
merged 1 commit into from
Apr 8, 2023

Conversation

zhangzujian
Copy link
Member

@zhangzujian zhangzujian commented Apr 7, 2023

Multus now requires a Kubernetes CNI plugin has been installed first. This patch fixes occasional multus installation failure.

What type of this PR

  • CI

Which issue(s) this PR fixes:

Fixes #(issue-number)

WHAT

🤖 Generated by Copilot at cb744d8

This pull request simplifies and improves the GitHub workflows and the Makefile for building and testing Kube-OVN. It also ensures that Multus is installed before applying a load balancer service to a pod network.

🤖 Generated by Copilot at cb744d8

Multus and OVN
moved to build-x86-image
workflow streamlined

HOW

🤖 Generated by Copilot at cb744d8

  • Simplify the installation of Multus and Kube-OVN in the build-x86-image.yaml workflow file by using the kind-install-lb-svc target in the Makefile (link, link)
  • Modify the kind-install-lb-svc target in the Makefile to use the kind-install target with flags and add the kind-install-multus target as a dependency (link)
  • Remove an empty line from the build-x86-image.yaml workflow file for formatting (link)

Multus now requires a Kubernetes CNI plugin has been installed first.
This patch fixes occasional multus installation failure.
@github-actions
Copy link
Contributor

github-actions bot commented Apr 7, 2023

  • The commit message should be more descriptive and informative.
  • The removal of the Install Multus step in the kubevirt-e2e job seems to be a mistake as it is still present in the scheduled-e2e job. This inconsistency should be addressed.
  • The kind-install-lb-svc target in the Makefile should be updated to include both kind-install-multus and kind-install with the appropriate flags.

@zhangzujian zhangzujian marked this pull request as ready for review April 7, 2023 06:17
@zhangzujian zhangzujian requested a review from oilbeater April 7, 2023 06:25
@zhangzujian zhangzujian merged commit c0ab835 into kubeovn:master Apr 8, 2023
@zhangzujian zhangzujian deleted the fix-multus-installation branch April 8, 2023 02:28
zhangzujian added a commit that referenced this pull request Apr 8, 2023
Multus now requires a Kubernetes CNI plugin has been installed first.
This patch fixes occasional multus installation failure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants