Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce test binary size and add missing webhook build #2610

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Conversation

oilbeater
Copy link
Collaborator

@oilbeater oilbeater commented Apr 6, 2023

What type of this PR

Examples of user facing changes:

  • CI

Which issue(s) this PR fixes:

Fixes #(issue-number)

WHAT

🤖 Generated by Copilot at 8890c3a

Reduce binary size and include webhook tests in end-to-end build. The Makefile.e2e file was modified to add the -ldflags "-w -s" option to the ginkgo build commands and to include the ./test/e2e/webhook directory in the e2e-build target.

🤖 Generated by Copilot at 8890c3a

ginkgo build flags
strip the binaries for speed
webhook joins e2e-build

HOW

🤖 Generated by Copilot at 8890c3a

  • Add -ldflags "-w -s" option to ginkgo build commands to strip debug information and symbol table from binaries and improve test performance and efficiency (link, )
  • Include ./test/e2e/webhook directory in e2e-build target to build webhook tests (link)

@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

  • The commit message is missing. Please add a descriptive commit message.
  • It seems like the diff only modifies the Makefile.e2e file. Please make sure that this is intentional and there are no other changes that were missed.
  • Consider adding comments to explain what each ginkgo build command does.
  • The -ldflags "-w -s" option can potentially cause issues with debugging and profiling. Consider adding a comment explaining why it was added and if there are any alternatives or workarounds.

@oilbeater oilbeater requested a review from zhangzujian April 6, 2023 05:49
@oilbeater oilbeater merged commit 9b57740 into master Apr 6, 2023
@oilbeater oilbeater deleted the ci/test branch April 6, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants