feat: support nic-hotplug to a running pod. #2521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oilbeater
requested changes
Mar 22, 2023
pkg/controller/pod.go
Outdated
| return | ||
| } | ||
|
|
||
| needUnHotPlug, needHotPlug := diffKubeovnNets(oldPodNets, podNets) |
There was a problem hiding this comment.
needUnHotPlug -> needHotUnPlug
There was a problem hiding this comment.
related name should all be changed
pkg/controller/pod.go
Outdated
| @@ -324,10 +324,25 @@ func (c *Controller) enqueueUpdatePod(oldObj, newObj interface{}) { | |||
| }() | |||
| return | |||
| } | |||
| // hotplug or unhotplug nic | |||
There was a problem hiding this comment.
unhotplug -> hot unplug
oilbeater
approved these changes
Mar 23, 2023
|
Great work, thanks! @xujunjie-cover |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Examples of user facing changes:
Support hotplug and unhotplug nic to a running pod.
Which issue(s) this PR fixes:
Fixes #2520