fix ovn-speaker router bug #2433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oilbeater
approved these changes
Mar 7, 2023
oilbeater
pushed a commit
that referenced
this pull request
Mar 7, 2023
Co-authored-by: Edison Meng (孟志慧)-浪潮数据 <mengzhihui01@inspur.com> (cherry picked from commit f4bef89)
oilbeater
pushed a commit
that referenced
this pull request
Mar 7, 2023
Co-authored-by: Edison Meng (孟志慧)-浪潮数据 <mengzhihui01@inspur.com> (cherry picked from commit f4bef89)
oilbeater
pushed a commit
that referenced
this pull request
Mar 7, 2023
Co-authored-by: Edison Meng (孟志慧)-浪潮数据 <mengzhihui01@inspur.com> (cherry picked from commit f4bef89)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
when the ovn-speaker uses BGP to update the route, it determines whether the route is sent by the local node by nexthop == router-id condition.This condition is incorrect.
The nexthop information carried in the BGP message sent by the local node must be the IP of the local node interface. So,we can use the route.Type == unix.RTN_LOCAL condition.