Add gateway monitor metrics and event #2345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changluyi
force-pushed
the
add_gateway_monitor_metrics_and_event
branch
2 times, most recently
from
92acc7c to
866a34d
Compare
oilbeater
requested changes
Feb 17, 2023
pkg/controller/subnet.go
Outdated
|
|
||
| if oldSubnet.Spec.GatewayType != newSubnet.Spec.GatewayType { | ||
| c.recorder.Eventf(newSubnet, v1.EventTypeNormal, "SubnetGatewayTypeChanged", | ||
| "subnet gateway type change from %s to %s ", oldSubnet.Spec.GatewayType, newSubnet.Spec.GatewayType) |
There was a problem hiding this comment.
Suggested change
| "subnet gateway type change from %s to %s ", oldSubnet.Spec.GatewayType, newSubnet.Spec.GatewayType) | |
| "subnet gateway type changes from %s to %s ", oldSubnet.Spec.GatewayType, newSubnet.Spec.GatewayType) |
pkg/controller/subnet.go
Outdated
|
|
||
| if oldSubnet.Spec.GatewayNode != newSubnet.Spec.GatewayNode { | ||
| c.recorder.Eventf(newSubnet, v1.EventTypeNormal, "SubnetGatewayNodeChanged", | ||
| "gateway node change from %s to %s ", oldSubnet.Spec.GatewayNode, newSubnet.Spec.GatewayNode) |
There was a problem hiding this comment.
Suggested change
| "gateway node change from %s to %s ", oldSubnet.Spec.GatewayNode, newSubnet.Spec.GatewayNode) | |
| "gateway node changes from %s to %s ", oldSubnet.Spec.GatewayNode, newSubnet.Spec.GatewayNode) |
| c.recorder.Eventf(newSubnet, v1.EventTypeNormal, "SubnetGatewayNodeChanged", | ||
| "gateway node change from %s to %s ", oldSubnet.Spec.GatewayNode, newSubnet.Spec.GatewayNode) | ||
| } | ||
|
|
There was a problem hiding this comment.
We should also care about the ActivateGateway and status changes between ready and not ready
pkg/daemon/metrics.go
Outdated
| @@ -66,6 +66,28 @@ var ( | |||
| []string{"code", "method", "host"}, | |||
| ) | |||
|
|
|||
| metricOvnSubnetGatewayPacketBytes = prometheus.NewGaugeVec(prometheus.GaugeOpts{ | |||
There was a problem hiding this comment.
We should use counter type as the number keeps increase
pkg/daemon/controller_linux.go
Outdated
| @@ -531,6 +531,11 @@ func (c *Controller) loopEncapIpCheck() { | |||
| } | |||
| } | |||
|
|
|||
| func (c *Controller) ovnMetricsUpdate() { | |||
| resetOvnSubnetGatewayMetrics() | |||
changluyi
force-pushed
the
add_gateway_monitor_metrics_and_event
branch
from
eab8242 to
f2cbcf1
Compare
changluyi
force-pushed
the
add_gateway_monitor_metrics_and_event
branch
from
a032854 to
7cf5bf3
Compare
oilbeater
requested changes
Feb 22, 2023
oilbeater
approved these changes
Feb 22, 2023
changluyi
force-pushed
the
add_gateway_monitor_metrics_and_event
branch
from
f5b5431 to
e787ce3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes:
Fixes #2233