feat: configure routes via pod annotation #2307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -248,15 +260,16 @@ | |||
| mtu = csh.Config.MTU | |||
| } | |||
|
|
|||
| klog.Infof("create container interface %s mac %s, ip %s, cidr %s, gw %s, custom routes %v", ifName, macAddr, ipAddr, cidr, gw, podRequest.Routes) | |||
| routes = append(podRequest.Routes, routes...) | |||
| klog.Infof("create container interface %s mac %s, ip %s, cidr %s, gw %s, custom routes %v", ifName, macAddr, ipAddr, cidr, gw, routes) | |||
Check failure
Code scanning / CodeQL
Log entries created from user input
| var dst *net.IPNet | ||
| if r.Destination != "" { | ||
| if _, dst, err = net.ParseCIDR(r.Destination); err != nil { | ||
| klog.Errorf("invalid route destination %s: %v", r.Destination, err) |
Check failure
Code scanning / CodeQL
Log entries created from user input
zhangzujian
force-pushed
the
feat/routes
branch
2 times, most recently
from
1e82fbe to
056e27b
Compare
zhangzujian
force-pushed
the
feat/routes
branch
from
056e27b to
a79540b
Compare
oilbeater
approved these changes
Feb 9, 2023
|
Need update the docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Which issue(s) this PR fixes:
Fixes #2275