-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ovn db: add support for listening on pod ip #2235
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangzujian
force-pushed
the
ovn-listen-pod-ip
branch
7 times, most recently
from
January 12, 2023 01:39
7cfe0cc
to
475e7a8
Compare
zhangzujian
force-pushed
the
ovn-listen-pod-ip
branch
3 times, most recently
from
January 12, 2023 06:53
c61970f
to
08a9901
Compare
zhangzujian
force-pushed
the
ovn-listen-pod-ip
branch
5 times, most recently
from
January 12, 2023 12:05
ae2bad7
to
92d862f
Compare
zhangzujian
force-pushed
the
ovn-listen-pod-ip
branch
from
January 16, 2023 04:06
92d862f
to
a36969e
Compare
zhangzujian
force-pushed
the
ovn-listen-pod-ip
branch
from
January 18, 2023 08:18
a36969e
to
5d26257
Compare
This reverts commit 8a1a3ca.
zhangzujian
force-pushed
the
ovn-listen-pod-ip
branch
from
January 18, 2023 08:28
5d26257
to
4f9be54
Compare
changluyi
approved these changes
Jan 19, 2023
cmd/daemon/cniserver.go
Outdated
addr = fmt.Sprintf("[%s]", podIps[0]) | ||
} | ||
} | ||
addr = os.Getenv("POD_IP") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the name "addr" is changed to "ip" in kube-ovn-controller/cmd
e2enode "k8s.io/kubernetes/test/e2e/framework/node" | ||
|
||
"github.com/onsi/ginkgo/v2" | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need white line
zhangzujian
added a commit
that referenced
this pull request
Jan 19, 2023
zhangzujian
added a commit
that referenced
this pull request
Jan 19, 2023
zhangzujian
added a commit
that referenced
this pull request
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Which issue(s) this PR fixes:
Fixes #2200