fix scheduled submariner e2e (#2469)

kubeovn · Mar 16, 2023 · e9dd289 · e9dd289
1 parent c66a93a
commit e9dd289
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 21 deletions.
diff --git a/.github/workflows/build-x86-image.yaml b/.github/workflows/build-x86-image.yaml
@@ -23,6 +23,7 @@ concurrency:
 env:
   GOSEC_VERSION: '2.15.0'
   HELM_VERSION: v3.11.1
+  SUBMARINER_VERSION: v0.13.4
 
 jobs:
   build-kube-ovn-base:
@@ -1578,10 +1579,10 @@ jobs:
           install_only: true
 
       - name: Install submariner subctl
-        run: |
-          curl -Ls https://get.submariner.io | VERSION=v0.13.4 bash
-          sudo chmod +x ~/.local/bin/subctl
-          sudo mv ~/.local/bin/subctl /usr/bin/
+        env:
+          VERSION: ${{ env.SUBMARINER_VERSION }}
+          DESTDIR: /usr/local/bin
+        run: curl -Ls https://get.submariner.io | bash
 
       - name: Download image
         uses: actions/download-artifact@v3

diff --git a/.github/workflows/scheduled-e2e.yaml b/.github/workflows/scheduled-e2e.yaml
@@ -11,6 +11,7 @@ concurrency:
 
 env:
   HELM_VERSION: v3.11.1
+  SUBMARINER_VERSION: v0.13.4
 
 jobs:
   k8s-conformance-e2e:
@@ -1217,9 +1218,6 @@ jobs:
       matrix:
         branch:
           - master
-          - release-1.11
-          - release-1.10
-          - release-1.9
     steps:
       - uses: actions/checkout@v3
 
@@ -1239,10 +1237,10 @@ jobs:
           install_only: true
 
       - name: Install submariner subctl
-        run: |
-          curl -Ls https://get.submariner.io | VERSION=v0.13.4 bash
-          sudo chmod +x ~/.local/bin/subctl
-          sudo mv ~/.local/bin/subctl /usr/bin/
+        env:
+          VERSION: ${{ env.SUBMARINER_VERSION }}
+          DESTDIR: /usr/local/bin
+        run: curl -Ls https://get.submariner.io | bash
 
       - name: Create kind cluster
         working-directory: test/e2e/kube-ovn/branches/${{ matrix.branch }}

diff --git a/Makefile b/Makefile
@@ -573,16 +573,10 @@ kind-install-lb-svc: kind-load-image kind-untaint-control-plane
 	kubectl describe no
 
 .PHONY: kind-install-webhook
-kind-install-webhook: kind-load-image kind-untaint-control-plane
-	$(call docker_ensure_image_exists,$(CERT_MANAGER_CONTROLLER))
-	$(call kind_load_image,kube-ovn,$(CERT_MANAGER_CONTROLLER))
-	$(call docker_ensure_image_exists,$(CERT_MANAGER_CAINJECTOR))
-	$(call kind_load_image,kube-ovn,$(CERT_MANAGER_CAINJECTOR))
-	$(call docker_ensure_image_exists,$(CERT_MANAGER_WEBHOOK))
-	$(call kind_load_image,kube-ovn,$(CERT_MANAGER_WEBHOOK))
-
-	sed 's/VERSION=.*/VERSION=$(VERSION)/' dist/images/install.sh | bash
-	kubectl describe no
+kind-install-webhook: kind-install
+	$(call kind_load_image,kube-ovn,$(CERT_MANAGER_CONTROLLER),1)
+	$(call kind_load_image,kube-ovn,$(CERT_MANAGER_CAINJECTOR),1)
+	$(call kind_load_image,kube-ovn,$(CERT_MANAGER_WEBHOOK),1)
 
 	kubectl apply -f "$(CERT_MANAGER_YAML)"
 	kubectl rollout status deployment/cert-manager -n cert-manager --timeout 120s