small installation tips for windows user #88
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
This change is |
|
Hi @xfate123. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -24,6 +24,7 @@ cd manifests/xgboost-job/xgboost-operator | |||
| kubectl create namespace kubeflow | |||
| kustomize build base | kubectl apply -f - | |||
| ``` | |||
| Note: for windows user, you might have invalid path error when you clone kubeflow/manifests repository, please use WSL instead | |||
There was a problem hiding this comment.
Add link to WSL?
Also remove “note :”
Why would they have issue git cloning the repo?
There was a problem hiding this comment.
If I use powershell to do the git clone for kubeflow/manifest repository will have following error
error: invalid path 'tests/tests/legacy_kustomizations/cert-manager-kube-system-resources/test_data/expected/rbac.authorization.k8s.io_v1beta1_role_cert-manager-cainjector:leaderelection.yaml'
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'
I think this is a common error for windows user
There was a problem hiding this comment.
There are some other ways to solve this problem for Windows user, some method might be a little bit easier if the user haven't installed WSL in their computer. But I guess most developer who use Windows has already installed WSL in their computer, then use WSL seems the easiest solution
There was a problem hiding this comment.
I can also put a link for other solution if the windows user don't want to install WSL.
https://brendanforster.com/notes/fixing-invalid-git-paths-on-windows/
There was a problem hiding this comment.
I am not sure if it makes sense to add this specific note that's git and OS specific. It sounds like this should be something a user would be figure out on their own by Googling around.
|
@terrytangyuan I am testing the new implementation right now, looks like there is a RunContainerError, should we update the image version in our deployment config file from v0.1.0 to v0.1.0-7-g34d49cc? |
I've created a separate issue #89 (comment) for this. For now, we can probably updating it manually. |
|
@terrytangyuan sounds good |
small installation tips for windows user